Browse Source

Change ResetToDefaultAsync to DeleteAsync

Also fixed the httpmethod problem
pull/14547/head
Halil İbrahim Kalkan 4 years ago
parent
commit
527e338422
  1. 2
      modules/feature-management/src/Volo.Abp.FeatureManagement.Application.Contracts/Volo/Abp/FeatureManagement/IFeatureAppService.cs
  2. 2
      modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs
  3. 2
      modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor/Components/FeatureManagementModal.razor.cs
  4. 4
      modules/feature-management/src/Volo.Abp.FeatureManagement.HttpApi.Client/ClientProxies/FeaturesClientProxy.Generated.cs
  5. 8
      modules/feature-management/src/Volo.Abp.FeatureManagement.HttpApi.Client/ClientProxies/featureManagement-generate-proxy.json
  6. 6
      modules/feature-management/src/Volo.Abp.FeatureManagement.HttpApi/Volo/Abp/FeatureManagement/FeaturesController.cs
  7. 2
      modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureAppService_Tests.cs

2
modules/feature-management/src/Volo.Abp.FeatureManagement.Application.Contracts/Volo/Abp/FeatureManagement/IFeatureAppService.cs

@ -10,5 +10,5 @@ public interface IFeatureAppService : IApplicationService
Task UpdateAsync([NotNull] string providerName, string providerKey, UpdateFeaturesDto input); Task UpdateAsync([NotNull] string providerName, string providerKey, UpdateFeaturesDto input);
Task ResetToDefaultAsync([NotNull] string providerName, string providerKey); Task DeleteAsync([NotNull] string providerName, string providerKey);
} }

2
modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs

@ -138,7 +138,7 @@ public class FeatureAppService : FeatureManagementAppServiceBase, IFeatureAppSer
await AuthorizationService.CheckAsync(policyName); await AuthorizationService.CheckAsync(policyName);
} }
public virtual async Task ResetToDefaultAsync([NotNull] string providerName, string providerKey) public virtual async Task DeleteAsync([NotNull] string providerName, string providerKey)
{ {
await FeatureValueRepository.DeleteAsync(providerName, providerKey); await FeatureValueRepository.DeleteAsync(providerName, providerKey);
} }

2
modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor/Components/FeatureManagementModal.razor.cs

@ -120,7 +120,7 @@ public partial class FeatureManagementModal
{ {
return; return;
} }
await FeatureAppService.ResetToDefaultAsync(ProviderName, ProviderKey); await FeatureAppService.DeleteAsync(ProviderName, ProviderKey);
await Message.Success(L["ResetedToDefault"]); await Message.Success(L["ResetedToDefault"]);
} }

4
modules/feature-management/src/Volo.Abp.FeatureManagement.HttpApi.Client/ClientProxies/FeaturesClientProxy.Generated.cs

@ -34,9 +34,9 @@ public partial class FeaturesClientProxy : ClientProxyBase<IFeatureAppService>,
}); });
} }
public virtual async Task ResetToDefaultAsync(string providerName, string providerKey) public virtual async Task DeleteAsync(string providerName, string providerKey)
{ {
await RequestAsync(nameof(ResetToDefaultAsync), new ClientProxyRequestTypeValue await RequestAsync(nameof(DeleteAsync), new ClientProxyRequestTypeValue
{ {
{ typeof(string), providerName }, { typeof(string), providerName },
{ typeof(string), providerKey } { typeof(string), providerKey }

8
modules/feature-management/src/Volo.Abp.FeatureManagement.HttpApi.Client/ClientProxies/featureManagement-generate-proxy.json

@ -150,10 +150,10 @@
"allowAnonymous": null, "allowAnonymous": null,
"implementFrom": "Volo.Abp.FeatureManagement.IFeatureAppService" "implementFrom": "Volo.Abp.FeatureManagement.IFeatureAppService"
}, },
"ResetToDefaultAsyncByProviderNameAndProviderKey": { "DeleteAsyncByProviderNameAndProviderKey": {
"uniqueName": "ResetToDefaultAsyncByProviderNameAndProviderKey", "uniqueName": "DeleteAsyncByProviderNameAndProviderKey",
"name": "ResetToDefaultAsync", "name": "DeleteAsync",
"httpMethod": null, "httpMethod": "DELETE",
"url": "api/feature-management/features", "url": "api/feature-management/features",
"supportedVersions": [], "supportedVersions": [],
"parametersOnMethod": [ "parametersOnMethod": [

6
modules/feature-management/src/Volo.Abp.FeatureManagement.HttpApi/Volo/Abp/FeatureManagement/FeaturesController.cs

@ -28,9 +28,9 @@ public class FeaturesController : AbpControllerBase, IFeatureAppService
return FeatureAppService.UpdateAsync(providerName, providerKey, input); return FeatureAppService.UpdateAsync(providerName, providerKey, input);
} }
[HttpPost] [HttpDelete]
public Task ResetToDefaultAsync(string providerName, string providerKey) public virtual Task DeleteAsync(string providerName, string providerKey)
{ {
return FeatureAppService.ResetToDefaultAsync(providerName, providerKey); return FeatureAppService.DeleteAsync(providerName, providerKey);
} }
} }

2
modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureAppService_Tests.cs

@ -73,7 +73,7 @@ public class FeatureAppService_Tests : FeatureManagementApplicationTestBase
{ {
Login(_testData.User1Id); Login(_testData.User1Id);
var exception = await Record.ExceptionAsync(async () => var exception = await Record.ExceptionAsync(async () =>
await _featureAppService.ResetToDefaultAsync("test", "test")); await _featureAppService.DeleteAsync("test", "test"));
Assert.Null(exception); Assert.Null(exception);
} }

Loading…
Cancel
Save