From 0f14fa44282ca0070e36b0ed92473032107df5d2 Mon Sep 17 00:00:00 2001 From: Halil ibrahim Kalkan Date: Mon, 11 Feb 2019 13:45:05 +0300 Subject: [PATCH 1/2] Added todo. --- .../Mvc/Client/CachedApplicationConfigurationClient.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/src/Volo.Abp.AspNetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/CachedApplicationConfigurationClient.cs b/framework/src/Volo.Abp.AspNetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/CachedApplicationConfigurationClient.cs index f7df64b257..557b7c8835 100644 --- a/framework/src/Volo.Abp.AspNetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/CachedApplicationConfigurationClient.cs +++ b/framework/src/Volo.Abp.AspNetCore.Mvc.Client/Volo/Abp/AspNetCore/Mvc/Client/CachedApplicationConfigurationClient.cs @@ -45,7 +45,7 @@ namespace Volo.Abp.AspNetCore.Mvc.Client async () => await Proxy.Service.GetAsync(), () => new DistributedCacheEntryOptions { - AbsoluteExpirationRelativeToNow = TimeSpan.FromSeconds(5) + AbsoluteExpirationRelativeToNow = TimeSpan.FromSeconds(30) //TODO: Should be configurable. Default value should be higher (5 mins would be good). } ); From 539add21077a28ed051719ef2909fb98ded06b5e Mon Sep 17 00:00:00 2001 From: Halil ibrahim Kalkan Date: Mon, 11 Feb 2019 13:45:18 +0300 Subject: [PATCH 2/2] Use single DependsOn --- .../Volo/Abp/Emailing/AbpEmailingModule.cs | 3 +-- .../MultiTenancy/AbpMultiTenancyAbstractionsModule.cs | 11 ++++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/AbpEmailingModule.cs b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/AbpEmailingModule.cs index 4a23ecae9a..7648ddc910 100644 --- a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/AbpEmailingModule.cs +++ b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/AbpEmailingModule.cs @@ -1,5 +1,4 @@ -using Microsoft.Extensions.DependencyInjection; -using Volo.Abp.BackgroundJobs; +using Volo.Abp.BackgroundJobs; using Volo.Abp.Emailing.Templates; using Volo.Abp.Emailing.Templates.Virtual; using Volo.Abp.Localization; diff --git a/framework/src/Volo.Abp.MultiTenancy.Abstractions/Volo/Abp/MultiTenancy/AbpMultiTenancyAbstractionsModule.cs b/framework/src/Volo.Abp.MultiTenancy.Abstractions/Volo/Abp/MultiTenancy/AbpMultiTenancyAbstractionsModule.cs index 05fc338c67..c695a84664 100644 --- a/framework/src/Volo.Abp.MultiTenancy.Abstractions/Volo/Abp/MultiTenancy/AbpMultiTenancyAbstractionsModule.cs +++ b/framework/src/Volo.Abp.MultiTenancy.Abstractions/Volo/Abp/MultiTenancy/AbpMultiTenancyAbstractionsModule.cs @@ -1,13 +1,14 @@ -using Microsoft.Extensions.DependencyInjection; -using Volo.Abp.Data; +using Volo.Abp.Data; using Volo.Abp.Modularity; using Volo.Abp.Settings; namespace Volo.Abp.MultiTenancy { - [DependsOn(typeof(AbpDataModule))] - [DependsOn(typeof(AbpSettingsModule))] - public class AbpMultiTenancyAbstractionsModule : AbpModule //TODO: Rename to AbpMultiTenancyModule + [DependsOn( + typeof(AbpDataModule), + typeof(AbpSettingsModule) + )] + public class AbpMultiTenancyAbstractionsModule : AbpModule //TODO: Rename to AbpMultiTenancyModule? { public override void ConfigureServices(ServiceConfigurationContext context) {