Browse Source

Merge pull request #18654 from abpframework/EngincanV/patch-1

CLI: Fix build error in the project creation command base.
pull/18666/head
selman koc 3 years ago
committed by GitHub
parent
commit
5332093b6b
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/NewCommand.cs
  2. 9
      framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/ProjectCreationCommandBase.cs

7
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/NewCommand.cs

@ -19,6 +19,7 @@ using Volo.Abp.Cli.ProjectBuilding.Events;
using Volo.Abp.Cli.ProjectBuilding.Templates.App; using Volo.Abp.Cli.ProjectBuilding.Templates.App;
using Volo.Abp.Cli.ProjectModification; using Volo.Abp.Cli.ProjectModification;
using Volo.Abp.Cli.Utils; using Volo.Abp.Cli.Utils;
using Volo.Abp.Cli.Version;
using Volo.Abp.DependencyInjection; using Volo.Abp.DependencyInjection;
using Volo.Abp.EventBus.Local; using Volo.Abp.EventBus.Local;
@ -44,7 +45,8 @@ public class NewCommand : ProjectCreationCommandBase, IConsoleCommand, ITransien
IBundlingService bundlingService, IBundlingService bundlingService,
ITemplateInfoProvider templateInfoProvider, ITemplateInfoProvider templateInfoProvider,
TemplateProjectBuilder templateProjectBuilder, TemplateProjectBuilder templateProjectBuilder,
AngularThemeConfigurer angularThemeConfigurer) : AngularThemeConfigurer angularThemeConfigurer,
CliVersionService cliVersionService) :
base(connectionStringProvider, base(connectionStringProvider,
solutionPackageVersionFinder, solutionPackageVersionFinder,
cmdHelper, cmdHelper,
@ -55,7 +57,8 @@ public class NewCommand : ProjectCreationCommandBase, IConsoleCommand, ITransien
themePackageAdder, themePackageAdder,
eventBus, eventBus,
bundlingService, bundlingService,
angularThemeConfigurer) angularThemeConfigurer,
cliVersionService)
{ {
TemplateInfoProvider = templateInfoProvider; TemplateInfoProvider = templateInfoProvider;
TemplateProjectBuilder = templateProjectBuilder; TemplateProjectBuilder = templateProjectBuilder;

9
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/ProjectCreationCommandBase.cs

@ -22,6 +22,7 @@ using Volo.Abp.Cli.ProjectBuilding.Templates.Microservice;
using Volo.Abp.Cli.ProjectBuilding.Templates.Module; using Volo.Abp.Cli.ProjectBuilding.Templates.Module;
using Volo.Abp.Cli.ProjectBuilding.Templates.MvcModule; using Volo.Abp.Cli.ProjectBuilding.Templates.MvcModule;
using Volo.Abp.Cli.Utils; using Volo.Abp.Cli.Utils;
using Volo.Abp.Cli.Version;
using Volo.Abp.EventBus.Local; using Volo.Abp.EventBus.Local;
namespace Volo.Abp.Cli.Commands; namespace Volo.Abp.Cli.Commands;
@ -42,6 +43,8 @@ public abstract class ProjectCreationCommandBase
public ThemePackageAdder ThemePackageAdder { get; } public ThemePackageAdder ThemePackageAdder { get; }
public AngularThemeConfigurer AngularThemeConfigurer { get; } public AngularThemeConfigurer AngularThemeConfigurer { get; }
public CliVersionService CliVersionService { get; }
public ProjectCreationCommandBase( public ProjectCreationCommandBase(
ConnectionStringProvider connectionStringProvider, ConnectionStringProvider connectionStringProvider,
@ -54,7 +57,8 @@ public abstract class ProjectCreationCommandBase
ThemePackageAdder themePackageAdder, ThemePackageAdder themePackageAdder,
ILocalEventBus eventBus, ILocalEventBus eventBus,
IBundlingService bundlingService, IBundlingService bundlingService,
AngularThemeConfigurer angularThemeConfigurer) AngularThemeConfigurer angularThemeConfigurer,
CliVersionService cliVersionService)
{ {
_bundlingService = bundlingService; _bundlingService = bundlingService;
ConnectionStringProvider = connectionStringProvider; ConnectionStringProvider = connectionStringProvider;
@ -67,6 +71,7 @@ public abstract class ProjectCreationCommandBase
EventBus = eventBus; EventBus = eventBus;
ThemePackageAdder = themePackageAdder; ThemePackageAdder = themePackageAdder;
AngularThemeConfigurer = angularThemeConfigurer; AngularThemeConfigurer = angularThemeConfigurer;
CliVersionService = cliVersionService;
Logger = NullLogger<NewCommand>.Instance; Logger = NullLogger<NewCommand>.Instance;
} }
@ -86,7 +91,7 @@ public abstract class ProjectCreationCommandBase
Logger.LogInformation("Preview: yes"); Logger.LogInformation("Preview: yes");
#if !DEBUG #if !DEBUG
var cliVersion = await CliService.GetCurrentCliVersionAsync(typeof(CliService).Assembly); var cliVersion = await CliVersionService.GetCurrentCliVersionAsync();
if (!cliVersion.IsPrerelease) if (!cliVersion.IsPrerelease)
{ {

Loading…
Cancel
Save