Browse Source

Merge pull request #23120 from abpframework/FeatureAppService

fix: ensure provider policy check before deleting feature
pull/23121/head
Halil İbrahim Kalkan 8 months ago
committed by GitHub
parent
commit
5b3cb72672
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs
  2. 8
      modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureManagementApplicationTestModule.cs

1
modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs

@ -137,6 +137,7 @@ public class FeatureAppService : FeatureManagementAppServiceBase, IFeatureAppSer
public virtual async Task DeleteAsync([NotNull] string providerName, string providerKey)
{
await CheckProviderPolicy(providerName, providerKey);
await FeatureManager.DeleteAsync(providerName, providerKey);
}
}

8
modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureManagementApplicationTestModule.cs

@ -8,5 +8,11 @@ namespace Volo.Abp.FeatureManagement;
)]
public class FeatureManagementApplicationTestModule : AbpModule
{
public override void ConfigureServices(ServiceConfigurationContext context)
{
Configure<FeatureManagementOptions>(options =>
{
options.ProviderPolicies["test"] = FeatureManagementPermissions.ManageHostFeatures;
});
}
}

Loading…
Cancel
Save