Browse Source

Refactor user tab values to use descriptive strings

Changed tab values in UsersComponent from numeric ('0', '1') to descriptive string identifiers ('user-info', 'roles') for improved readability and maintainability.
pull/24689/head
Fahri Gedik 8 months ago
parent
commit
5f5539d5c6
  1. 8
      npm/ng-packs/packages/identity/src/lib/components/users/users.component.html
  2. 4
      npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts

8
npm/ng-packs/packages/identity/src/lib/components/users/users.component.html

@ -30,22 +30,22 @@
<form [formGroup]="form" (ngSubmit)="save()">
<div ngTabs selectionMode="follow">
<div ngTabList [(selectedTab)]="selectedTab" class="nav nav-tabs">
<button ngTab #tabInfo="ngTab" [value]="'0'" class="nav-link" [class.active]="tabInfo.selected()" type="button">
<button ngTab #tabInfo="ngTab" [value]="'user-info'" class="nav-link" [class.active]="tabInfo.selected()" type="button">
{{ 'AbpIdentity::UserInformations' | abpLocalization }}
</button>
<button ngTab #tabRoles="ngTab" [value]="'1'" class="nav-link" [class.active]="tabRoles.selected()" type="button">
<button ngTab #tabRoles="ngTab" [value]="'roles'" class="nav-link" [class.active]="tabRoles.selected()" type="button">
{{ 'AbpIdentity::Roles' | abpLocalization }}
</button>
</div>
<div class="mt-2 fade-in-top">
<div ngTabPanel [value]="'0'">
<div ngTabPanel [value]="'user-info'">
<ng-template ngTabContent>
<abp-extensible-form [selectedRecord]="selected"></abp-extensible-form>
</ng-template>
</div>
<div ngTabPanel [value]="'1'">
<div ngTabPanel [value]="'roles'">
<ng-template ngTabContent>
@for (roleGroup of roleGroups; track $index; let i = $index) {
<div class="form-check mb-2">

4
npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts

@ -106,7 +106,7 @@ export class UsersComponent implements OnInit {
selected?: IdentityUserDto;
selectedTab = '0';
selectedTab = 'user-info';
selectedUserRoles?: IdentityRoleDto[];
@ -166,7 +166,7 @@ export class UsersComponent implements OnInit {
}
openModal() {
this.selectedTab = '0';
this.selectedTab = 'user-info';
this.buildForm();
this.isModalVisible = true;
}

Loading…
Cancel
Save