Merge pull request #6275 from abpframework/refactor/6273

Deprecated the attribute usage of PermissonDirective

docs/en/Tutorials/Part-5.md

@@ -423,13 +423,13 @@ Open the `/src/app/book/book.component.html` file and replace the create button
 
 ````html
 <!-- Add the abpPermission directive -->
-<button abpPermission="BookStore.Books.Create" id="create" class="btn btn-primary" type="button" (click)="createBook()">
+<button *abpPermission="'BookStore.Books.Create'" id="create" class="btn btn-primary" type="button" (click)="createBook()">
   <i class="fa fa-plus mr-1"></i>
   <span>{%{{{ '::NewBook' | abpLocalization }}}%}</span>
 </button>
 ````
 
-* Just added `abpPermission="BookStore.Books.Create"` that hides the button if the current user has no permission.
+* Just added `*abpPermission="'BookStore.Books.Create'"` that hides the button if the current user has no permission.
 
 ### Hide the Edit and Delete Actions
 
@@ -443,18 +443,18 @@ Open the `/src/app/book/book.component.html` file and replace the edit and delet
 
 ````html
 <!-- Add the abpPermission directive -->
-<button abpPermission="BookStore.Books.Edit" ngbDropdownItem (click)="editBook(row.id)">
+<button *abpPermission="'BookStore.Books.Edit'" ngbDropdownItem (click)="editBook(row.id)">
   {%{{{ '::Edit' | abpLocalization }}}%}
 </button>
 
 <!-- Add the abpPermission directive -->
-<button abpPermission="BookStore.Books.Delete" ngbDropdownItem (click)="delete(row.id)">
+<button *abpPermission="'BookStore.Books.Delete'" ngbDropdownItem (click)="delete(row.id)">
   {%{{{ '::Delete' | abpLocalization }}}%}
 </button>
 ````
 
-* Added `abpPermission="BookStore.Books.Edit"` that hides the edit action if the current user has no editing permission.
-* Added `abpPermission="BookStore.Books.Delete"` that hides the delete action if the current user has no delete permission.
+* Added `*abpPermission="'BookStore.Books.Edit'"` that hides the edit action if the current user has no editing permission.
+* Added `*abpPermission="'BookStore.Books.Delete'"` that hides the delete action if the current user has no delete permission.
 
 {{else if UI == "Blazor"}}
 

docs/en/UI/Angular/Permission-Management.md

@@ -54,8 +54,6 @@ You can use the `PermissionDirective` to manage visibility of a DOM Element acco
 
 As shown above you can remove elements from DOM with `abpPermission` structural directive.
 
-The directive can also be used as an attribute directive but we recommend to you to use it as a structural directive.
-
 ## Permission Guard
 
 You can use `PermissionGuard` if you want to control authenticated user's permission to access to the route during navigation.

npm/ng-packs/angular.json

@@ -378,7 +378,6 @@
             "polyfills": "apps/dev-app/src/polyfills.ts",
             "tsConfig": "apps/dev-app/tsconfig.dev.json",
             "aot": true,
-            "extractCss": true,
             "allowedCommonJsDependencies": ["chart.js", "js-sha256"],
             "assets": ["apps/dev-app/src/favicon.ico", "apps/dev-app/src/assets"],
             "styles": [
@@ -433,7 +432,6 @@
               "optimization": true,
               "outputHashing": "all",
               "sourceMap": false,
-              "extractCss": true,
               "namedChunks": false,
               "extractLicenses": true,
               "vendorChunk": false,

npm/ng-packs/packages/core/src/lib/directives/permission.directive.ts

@@ -1,59 +1,64 @@
 import {
+  ChangeDetectorRef,
   Directive,
   ElementRef,
   Input,
   OnChanges,
   OnDestroy,
-  OnInit,
   Optional,
   Renderer2,
-  SimpleChanges,
   TemplateRef,
   ViewContainerRef,
 } from '@angular/core';
 import { Subscription } from 'rxjs';
+import { distinctUntilChanged } from 'rxjs/operators';
 import { PermissionService } from '../services/permission.service';
 
 @Directive({
   selector: '[abpPermission]',
 })
-export class PermissionDirective implements OnInit, OnDestroy, OnChanges {
+export class PermissionDirective implements OnDestroy, OnChanges {
   @Input('abpPermission') condition: string;
 
   subscription: Subscription;
 
   constructor(
-    private elRef: ElementRef,
+    private elRef: ElementRef<HTMLElement>,
     private renderer: Renderer2,
     @Optional() private templateRef: TemplateRef<any>,
     private vcRef: ViewContainerRef,
     private permissionService: PermissionService,
+    private cdRef: ChangeDetectorRef,
   ) {}
 
   private check() {
     if (this.subscription) {
       this.subscription.unsubscribe();
     }
+
     this.subscription = this.permissionService
       .getGrantedPolicy$(this.condition)
+      .pipe(distinctUntilChanged())
       .subscribe(isGranted => {
-        if (this.templateRef && isGranted) {
-          this.vcRef.clear();
-          this.vcRef.createEmbeddedView(this.templateRef);
-        } else if (this.templateRef && !isGranted) {
-          this.vcRef.clear();
-        } else if (!isGranted && !this.templateRef) {
-          this.renderer.removeChild(
-            (this.elRef.nativeElement as HTMLElement).parentElement,
-            this.elRef.nativeElement,
-          );
-        }
+        if (this.templateRef) this.initStructural(isGranted);
+        else this.initAttribute(isGranted);
+
+        this.cdRef.detectChanges();
       });
   }
 
-  ngOnInit() {
-    if (this.templateRef && !this.condition) {
-      this.vcRef.createEmbeddedView(this.templateRef);
+  private initStructural(isGranted: boolean) {
+    this.vcRef.clear();
+
+    if (isGranted) this.vcRef.createEmbeddedView(this.templateRef);
+  }
+
+  /**
+   * @deprecated Will be deleted in v5.0
+   */
+  private initAttribute(isGranted: boolean) {
+    if (!isGranted) {
+      this.renderer.removeChild(this.elRef.nativeElement.parentElement, this.elRef.nativeElement);
     }
   }
 
@@ -61,9 +66,7 @@ export class PermissionDirective implements OnInit, OnDestroy, OnChanges {
     if (this.subscription) this.subscription.unsubscribe();
   }
 
-  ngOnChanges({ condition }: SimpleChanges) {
-    if ((condition || { currentValue: null }).currentValue) {
-      this.check();
-    }
+  ngOnChanges() {
+    this.check();
   }
 }

npm/ng-packs/packages/core/src/lib/services/config-state.service.ts

@@ -15,7 +15,7 @@ export class ConfigStateService {
   }
 
   setState = (state: ApplicationConfiguration.Response) => {
-    this.store.patch(state);
+    this.store.set(state);
   };
 
   getOne$(key: string) {

npm/ng-packs/packages/core/src/lib/services/environment.service.ts

@@ -31,6 +31,6 @@ export class EnvironmentService {
   }
 
   setState(environment: Environment) {
-    this.store.patch(environment);
+    this.store.set(environment);
   }
 }

npm/ng-packs/packages/core/src/lib/services/permission.service.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { map } from 'rxjs/operators';
+import { map, tap } from 'rxjs/operators';
 import snq from 'snq';
 import { ApplicationConfiguration } from '../models/application-configuration';
 import { ConfigStateService } from './config-state.service';
@@ -9,7 +9,9 @@ export class PermissionService {
   constructor(private configState: ConfigStateService) {}
 
   getGrantedPolicy$(key: string) {
-    return this.getStream().pipe(map(policies => this.isPolicyGranted(key, policies)));
+    return this.getStream().pipe(
+      map(grantedPolicies => this.isPolicyGranted(key, grantedPolicies)),
+    );
   }
 
   getGrantedPolicy(key: string) {
@@ -17,7 +19,7 @@ export class PermissionService {
     return this.isPolicyGranted(key, policies);
   }
 
-  private isPolicyGranted(key: string, policies: ApplicationConfiguration.Policy) {
+  private isPolicyGranted(key: string, grantedPolicies: ApplicationConfiguration.Policy) {
     if (!key) return true;
 
     const orRegexp = /\|\|/g;
@@ -29,16 +31,16 @@ export class PermissionService {
 
       if (keys.length < 2) return false;
 
-      return keys.some(k => this.getPolicy(k.trim(), policies));
+      return keys.some(k => this.getPolicy(k.trim(), grantedPolicies));
     } else if (andRegexp.test(key)) {
       const keys = key.split('&&').filter(Boolean);
 
       if (keys.length < 2) return false;
 
-      return keys.every(k => this.getPolicy(k.trim(), policies));
+      return keys.every(k => this.getPolicy(k.trim(), grantedPolicies));
     }
 
-    return this.getPolicy(key, policies);
+    return this.getPolicy(key, grantedPolicies);
   }
 
   private getStream() {
@@ -53,7 +55,7 @@ export class PermissionService {
     return snq(() => applicationConfiguration.auth.grantedPolicies);
   }
 
-  private getPolicy(policy: string, policies: ApplicationConfiguration.Policy) {
-    return snq(() => policies[policy], false);
+  private getPolicy(key: string, grantedPolicies: ApplicationConfiguration.Policy) {
+    return snq(() => grantedPolicies[key], false);
   }
 }

npm/ng-packs/packages/core/src/lib/utils/internal-store-utils.ts

@@ -30,6 +30,11 @@ export class InternalStore<State> {
     this.update$.next(state);
   }
 
+  set(state: State) {
+    this.state$.next(state);
+    this.update$.next(state);
+  }
+
   reset() {
     this.patch(this.initialState);
   }

npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.html

@@ -51,14 +51,15 @@
               >
                 {{ 'AbpIdentity::Permissions' | abpLocalization }}
               </button>
-              <button
-                *ngIf="!row.isStatic"
-                [abpPermission]="'AbpIdentity.Roles.Delete'"
-                ngbDropdownItem
-                (click)="delete(row.id, row.name)"
-              >
-                {{ 'AbpIdentity::Delete' | abpLocalization }}
-              </button>
+              <ng-container *ngIf="!row.isStatic">
+                <button
+                  *abpPermission="'AbpIdentity.Roles.Delete'"
+                  ngbDropdownItem
+                  (click)="delete(row.id, row.name)"
+                >
+                  {{ 'AbpIdentity::Delete' | abpLocalization }}
+                </button>
+              </ng-container>
             </div>
           </div>
         </ng-template>

npm/ng-packs/packages/setting-management/src/lib/components/setting-management.component.html

@@ -16,20 +16,21 @@
       <div class="row">
         <div class="col-12 col-md-3">
           <ul class="nav flex-column nav-pills" id="nav-tab" role="tablist">
-            <li
-              *abpFor="let setting of settings; trackBy: trackByFn"
-              (click)="selected = setting"
-              class="nav-item pointer"
-              [abpPermission]="setting.requiredPolicy"
-            >
-              <a
-                class="nav-link"
-                [id]="setting.name + '-tab'"
-                role="tab"
-                [class.active]="setting.name === selected.name"
-                >{{ setting.name | abpLocalization }}</a
+            <ng-container *abpFor="let setting of settings; trackBy: trackByFn">
+              <li
+                (click)="selected = setting"
+                class="nav-item pointer"
+                *abpPermission="setting.requiredPolicy"
               >
-            </li>
+                <a
+                  class="nav-link"
+                  [id]="setting.name + '-tab'"
+                  role="tab"
+                  [class.active]="setting.name === selected.name"
+                  >{{ setting.name | abpLocalization }}</a
+                >
+              </li>
+            </ng-container>
           </ul>
         </div>
         <div class="col-12 col-md-9">

npm/ng-packs/packages/theme-basic/src/lib/components/nav-items/nav-items.component.html

@@ -1,18 +1,16 @@
 <ul class="navbar-nav">
   <ng-container *ngFor="let item of navItems.items$ | async; trackBy: trackByFn">
-    <li
-      class="nav-item d-flex align-items-center"
-      *ngIf="item.visible()"
-      [abpPermission]="item.requiredPolicy"
-    >
-      <ng-container
-        *ngIf="item.component; else htmlTemplate"
-        [ngComponentOutlet]="item.component"
-      ></ng-container>
+    <ng-container *ngIf="item.visible()">
+      <li class="nav-item d-flex align-items-center" *abpPermission="item.requiredPolicy">
+        <ng-container
+          *ngIf="item.component; else htmlTemplate"
+          [ngComponentOutlet]="item.component"
+        ></ng-container>
 
-      <ng-template #htmlTemplate>
-        <div [innerHTML]="item.html" (click)="item.action ? item.action() : null"></div>
-      </ng-template>
-    </li>
+        <ng-template #htmlTemplate>
+          <div [innerHTML]="item.html" (click)="item.action ? item.action() : null"></div>
+        </ng-template>
+      </li>
+    </ng-container>
   </ng-container>
 </ul>

npm/ng-packs/packages/theme-basic/src/lib/components/routes/routes.component.html

@@ -16,37 +16,40 @@
   </ng-template>
 
   <ng-template #dropdownLink let-route>
-    <li
-      #navbarRootDropdown
-      class="nav-item dropdown"
-      display="static"
-      *ngIf="route.children?.length"
-      [abpPermission]="route.requiredPolicy"
-      (click)="
-        navbarRootDropdown.expand
-          ? (navbarRootDropdown.expand = false)
-          : (navbarRootDropdown.expand = true)
-      "
-    >
-      <a
-        class="nav-link dropdown-toggle"
-        data-toggle="dropdown"
-        aria-haspopup="true"
-        aria-expanded="false"
-        href="javascript:void(0)"
-      >
-        <i *ngIf="route.iconClass" [ngClass]="route.iconClass"></i>
-        {{ route.name | abpLocalization }}
-      </a>
-      <div
-        #routeContainer
-        class="dropdown-menu border-0 shadow-sm"
-        (click)="$event.preventDefault(); $event.stopPropagation()"
-        [class.d-block]="smallScreen && navbarRootDropdown.expand"
+    <ng-container *ngIf="route.children?.length">
+      <li
+        #navbarRootDropdown
+        class="nav-item dropdown"
+        display="static"
+        *abpPermission="route.requiredPolicy"
+        (click)="
+          navbarRootDropdown.expand
+            ? (navbarRootDropdown.expand = false)
+            : (navbarRootDropdown.expand = true)
+        "
       >
-        <ng-container *ngTemplateOutlet="forTemplate; context: { $implicit: route }"></ng-container>
-      </div>
-    </li>
+        <a
+          class="nav-link dropdown-toggle"
+          data-toggle="dropdown"
+          aria-haspopup="true"
+          aria-expanded="false"
+          href="javascript:void(0)"
+        >
+          <i *ngIf="route.iconClass" [ngClass]="route.iconClass"></i>
+          {{ route.name | abpLocalization }}
+        </a>
+        <div
+          #routeContainer
+          class="dropdown-menu border-0 shadow-sm"
+          (click)="$event.preventDefault(); $event.stopPropagation()"
+          [class.d-block]="smallScreen && navbarRootDropdown.expand"
+        >
+          <ng-container
+            *ngTemplateOutlet="forTemplate; context: { $implicit: route }"
+          ></ng-container>
+        </div>
+      </li>
+    </ng-container>
   </ng-template>
 
   <ng-template #forTemplate let-route>
@@ -74,7 +77,7 @@
       #dropdownSubmenu="ngbDropdown"
       placement="right-top"
       [autoClose]="true"
-      [abpPermission]="child.requiredPolicy"
+      *abpPermission="child.requiredPolicy"
     >
       <div ngbDropdownToggle [class.dropdown-toggle]="false">
         <a

npm/ng-packs/packages/theme-shared/extensions/src/lib/components/extensible-form/extensible-form-prop.component.html

@@ -1,4 +1,4 @@
-<div class="form-group" [abpPermission]="prop.permission" [ngSwitch]="getComponent(prop)">
+<div class="form-group" *abpPermission="prop.permission" [ngSwitch]="getComponent(prop)">
   <ng-template ngSwitchCase="input">
     <label [htmlFor]="prop.id">{{ prop.displayName | abpLocalization }} {{ asterisk }}</label>
     <input

npm/ng-packs/packages/theme-shared/extensions/src/lib/components/extensible-table/extensible-table.component.html

@@ -11,11 +11,7 @@
         *ngTemplateOutlet="actionsTemplate || gridActions; context: { $implicit: row, index: i }"
       ></ng-container>
       <ng-template #gridActions>
-        <abp-grid-actions
-          [index]="i"
-          [record]="row"
-          text="AbpUi::Actions"
-        ></abp-grid-actions>
+        <abp-grid-actions [index]="i" [record]="row" text="AbpUi::Actions"></abp-grid-actions>
       </ng-template>
     </ng-template>
   </ngx-datatable-column>
@@ -28,11 +24,13 @@
       [sortable]="prop.sortable"
     >
       <ng-template let-row="row" let-i="index" ngx-datatable-cell-template>
-        <ng-container [abpPermission]="prop.permission">
+        <ng-container *abpPermission="prop.permission">
           <div
             *ngIf="row['_' + prop.name].visible"
             [innerHTML]="row['_' + prop.name].value | async"
-            (click)="prop.action && prop.action({ getInjected: getInjected, record: row, index: i })"
+            (click)="
+              prop.action && prop.action({ getInjected: getInjected, record: row, index: i })
+            "
             [class.pointer]="prop.action"
           ></div>
         </ng-container>

npm/ng-packs/packages/theme-shared/extensions/src/lib/components/grid-actions/grid-actions.component.html

@@ -24,19 +24,20 @@
 ></ng-container>
 
 <ng-template #btnItem let-action>
-  <button
-    *ngIf="action.visible(data)"
-    ngbDropdownItem
-    [abpPermission]="action.permission"
-    (click)="action.action(data)"
-    type="button"
-    class="{{ actionList.length === 1 ? 'btn btn-primary' : '' }}"
-    [class.text-center]="actionList.length === 1"
-  >
-    <i [ngClass]="action.icon" [class.mr-1]="action.icon"></i>
-    <span *ngIf="action.icon; else ellipsis">{{ action.text | abpLocalization }}</span>
-    <ng-template #ellipsis>
-      <div abpEllipsis>{{ action.text | abpLocalization }}</div>
-    </ng-template>
-  </button>
+  <ng-container *ngIf="action.visible(data)">
+    <button
+      ngbDropdownItem
+      *abpPermission="action.permission"
+      (click)="action.action(data)"
+      type="button"
+      class="{{ actionList.length === 1 ? 'btn btn-primary' : '' }}"
+      [class.text-center]="actionList.length === 1"
+    >
+      <i [ngClass]="action.icon" [class.mr-1]="action.icon"></i>
+      <span *ngIf="action.icon; else ellipsis">{{ action.text | abpLocalization }}</span>
+      <ng-template #ellipsis>
+        <div abpEllipsis>{{ action.text | abpLocalization }}</div>
+      </ng-template>
+    </button>
+  </ng-container>
 </ng-template>

npm/ng-packs/packages/theme-shared/extensions/src/lib/components/page-toolbar/page-toolbar.component.html

@@ -1,18 +1,20 @@
 <div class="row justify-content-end mx-n1" id="AbpContentToolbar">
   <div class="col-auto px-1 pt-2" *ngFor="let action of actionList; trackBy: trackByFn">
-    <ng-container *ngIf="action.visible(data)" [abpPermission]="action.permission">
-      <ng-container *ngIf="action.component as component; else button">
-        <ng-container
-          *ngComponentOutlet="component; injector: createInjector(action)"
-        ></ng-container>
-      </ng-container>
+    <ng-container *ngIf="action.visible(data)">
+      <ng-container *abpPermission="action.permission">
+        <ng-container *ngIf="action.component as component; else button">
+          <ng-container
+            *ngComponentOutlet="component; injector: createInjector(action)"
+          ></ng-container>
+        </ng-container>
 
-      <ng-template #button>
-        <button (click)="action.action(data)" type="button" class="btn btn-primary btn-sm">
-          <i [ngClass]="action.icon" [class.mr-1]="action.icon"></i>
-          {{ action.text | abpLocalization }}
-        </button>
-      </ng-template>
+        <ng-template #button>
+          <button (click)="action.action(data)" type="button" class="btn btn-primary btn-sm">
+            <i [ngClass]="action.icon" [class.mr-1]="action.icon"></i>
+            {{ action.text | abpLocalization }}
+          </button>
+        </ng-template>
+      </ng-container>
     </ng-container>
   </div>
 </div>