Remove IsTransient from Entity.

src/Volo.Abp.Ddd/Volo/Abp/Domain/Entities/Entity.cs

@@ -22,12 +22,6 @@ namespace Volo.Abp.Domain.Entities
         /// <inheritdoc/>
         public virtual TPrimaryKey Id { get; set; }
 
-        /// <inheritdoc/>
-        public virtual bool IsTransient()
-        {
-            return EntityHelper.IsTransient(this);
-        }
-
         /// <inheritdoc/>
         public override bool Equals(object obj)
         {
@@ -44,7 +38,7 @@ namespace Volo.Abp.Domain.Entities
 
             //Transient objects are not considered as equal
             var other = (Entity<TPrimaryKey>)obj;
-            if (IsTransient() && other.IsTransient())
+            if (EntityHelper.IsTransient(this) && EntityHelper.IsTransient(other))
             {
                 return false;
             }

src/Volo.Abp.Ddd/Volo/Abp/Domain/Entities/EntityHelper.cs

@@ -25,7 +25,7 @@ namespace Volo.Abp.Domain.Entities
         /// This method is exists to help developers who want to directly implement <see cref="IEntity{TPrimaryKey}.IsTransient"/>
         /// but want to use default IsTransient implementation as a shortcut.
         /// </summary>
-        public static bool IsTransient<TPrimaryKey>(IEntity<TPrimaryKey> entity)
+        public static bool IsTransient<TPrimaryKey>(IEntity<TPrimaryKey> entity) // TODO: Completely remove IsTransient
         {
             if (EqualityComparer<TPrimaryKey>.Default.Equals(entity.Id, default))
             {

src/Volo.Abp.Ddd/Volo/Abp/Domain/Entities/IEntity.cs

@@ -20,11 +20,5 @@ namespace Volo.Abp.Domain.Entities
         /// Unique identifier for this entity.
         /// </summary>
         TPrimaryKey Id { get; set; }
-
-        /// <summary>
-        /// Checks if this entity is transient (not persisted to database and it has not an <see cref="Id"/>).
-        /// </summary>
-        /// <returns>True, if this entity is transient</returns>
-        bool IsTransient();
     }
 }

src/Volo.Abp.MemoryDb/Volo/Abp/Domain/Repositories/MemoryDb/MemoryDbRepository.cs

@@ -42,7 +42,7 @@ namespace Volo.Abp.Domain.Repositories.MemoryDb
         {
             if (typeof(TPrimaryKey) == typeof(int) || typeof(TPrimaryKey) == typeof(long) || typeof(TPrimaryKey) == typeof(Guid))
             {
-                if (entity.IsTransient())
+                if (EntityHelper.IsTransient(entity))
                 {
                     entity.Id = Database.GenerateNextId<TEntity, TPrimaryKey>();
                 }