Browse Source

Make GlobalFeature abstract.

pull/5062/head
Halil İbrahim Kalkan 6 years ago
parent
commit
6a24a0de30
  1. 10
      modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeature.cs
  2. 5
      modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeatureManagerModuleConfigurator.cs
  3. 4
      modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/CmsKitDomainSharedModule.cs
  4. 2
      modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/CommentsFeature.cs
  5. 2
      modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/ReactionsFeature.cs

10
modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeatureConfigurator.cs → modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeature.cs

@ -2,7 +2,7 @@
namespace Volo.Abp.GlobalFeatures
{
public class GlobalFeature
public abstract class GlobalFeature
{
[NotNull]
public GlobalModuleFeatures Module { get; }
@ -18,13 +18,11 @@ namespace Volo.Abp.GlobalFeatures
set => FeatureManager.SetEnabled(FeatureName, value);
}
public GlobalFeature(
[NotNull] GlobalModuleFeatures module,
[NotNull] string name)
protected GlobalFeature([NotNull] GlobalModuleFeatures module)
{
Module = Check.NotNull(module, nameof(module));
FeatureName = Check.NotNullOrWhiteSpace(name, nameof(name));
FeatureManager = Module.FeatureManager;
FeatureName = GlobalFeatureNameAttribute.GetName(GetType());
}
public virtual void Enable()
@ -39,7 +37,7 @@ namespace Volo.Abp.GlobalFeatures
public virtual void SetEnabled(bool isEnabled)
{
FeatureManager.SetEnabled(FeatureName, isEnabled);
}
}
}

5
modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/Abp/GlobalFeatures/GlobalFeatureManagerModuleConfigurator.cs

@ -33,11 +33,6 @@ namespace Volo.Abp.GlobalFeatures
}
}
protected void AddFeature(string featureName)
{
AddFeature(new GlobalFeature(this, featureName));
}
protected void AddFeature(GlobalFeature feature)
{
AllFeatures[feature.FeatureName] = feature;

4
modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/CmsKitDomainSharedModule.cs

@ -6,6 +6,7 @@ using Volo.Abp.Localization.ExceptionHandling;
using Volo.Abp.Validation;
using Volo.Abp.Validation.Localization;
using Volo.Abp.VirtualFileSystem;
using Volo.CmsKit.GlobalFeatures;
namespace Volo.CmsKit
{
@ -26,7 +27,8 @@ namespace Volo.CmsKit
cmsKit.Comments.Enable();
});
GlobalFeatureManager.Instance.IsEnabled("asd");
GlobalFeatureManager.Instance.IsEnabled("qweasd");
GlobalFeatureManager.Instance.IsEnabled<ReactionsFeature>();
Configure<AbpVirtualFileSystemOptions>(options =>
{

2
modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/CommentsFeature.cs

@ -10,7 +10,7 @@ namespace Volo.CmsKit.GlobalFeatures
public CommentsFeature(
[NotNull] GlobalCmsKitFeatures cmsKit
) : base(cmsKit, Name)
) : base(cmsKit)
{
}
}

2
modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/GlobalFeatures/ReactionsFeature.cs

@ -10,7 +10,7 @@ namespace Volo.CmsKit.GlobalFeatures
public ReactionsFeature(
[NotNull] GlobalCmsKitFeatures cmsKit
) : base(cmsKit, Name)
) : base(cmsKit)
{
}
}

Loading…
Cancel
Save