From 6a525aacd984a85d90a93783d9599e662bef36d5 Mon Sep 17 00:00:00 2001 From: maliming Date: Tue, 11 Aug 2026 10:19:00 +0800 Subject: [PATCH] Shorten the action menu and feature dialog comments --- .../Components/AbpMudActionMenu.razor.cs | 11 ++++------- .../Components/AbpMudActionMenuItem.razor.cs | 5 ++--- .../Components/FeatureManagementModal.razor | 5 ++--- .../Components/FeatureManagementModal.razor.cs | 7 +++---- 4 files changed, 11 insertions(+), 17 deletions(-) diff --git a/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenu.razor.cs b/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenu.razor.cs index 7a4b1f3ed3..ff0ff5efc9 100644 --- a/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenu.razor.cs +++ b/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenu.razor.cs @@ -9,8 +9,7 @@ using MudBlazor; namespace Volo.Abp.MudBlazorUI.Components; /// -/// A for entity/row actions that open a dialog. -/// Use it together with . +/// A for actions that open a dialog. Use it with . /// public partial class AbpMudActionMenu : ComponentBase { @@ -35,8 +34,7 @@ public partial class AbpMudActionMenu : ComponentBase public string? Label { get; set; } /// - /// The accessible name of the activator. An activator without a falls back - /// to the localized "Actions" text. + /// The accessible name of an activator that has no . Defaults to "Actions". /// [Parameter] public string? AriaLabel { get; set; } @@ -125,9 +123,8 @@ public partial class AbpMudActionMenu : ComponentBase } /// - /// Closes the whole menu hierarchy. calls this before running - /// its handler, because MudBlazor restores the focus to the activator while closing and that - /// would take the focus out of a dialog the handler opened. + /// Closes the whole menu hierarchy. MudBlazor restores the focus to the activator while closing, + /// so calls this before its handler opens a dialog. /// public virtual async Task CloseAsync() { diff --git a/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenuItem.razor.cs b/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenuItem.razor.cs index 2d3e230394..48299b84a2 100644 --- a/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenuItem.razor.cs +++ b/framework/src/Volo.Abp.MudBlazorUI/Components/AbpMudActionMenuItem.razor.cs @@ -7,9 +7,8 @@ using MudBlazor; namespace Volo.Abp.MudBlazorUI.Components; /// -/// A menu item that closes its menu before running , so a dialog opened by -/// the handler keeps the focus. Works inside an and inside a plain -/// . +/// A menu item that closes its menu before running , so a dialog opened by the +/// handler keeps the focus. Works in an and in a plain . /// public partial class AbpMudActionMenuItem : ComponentBase { diff --git a/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor b/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor index a718e6fadb..baa5e43fb8 100644 --- a/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor +++ b/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor @@ -20,7 +20,7 @@ PanelClass="pa-4"> @{ @* The features come from the definitions, so there is no known input to put - AutoFocus on. The first panel gets a container that takes the focus instead. *@ + AutoFocus on. The first panel gets a container that takes the focus. *@ RenderFragment renderGroup = group => @ @group.DisplayName @@ -74,8 +74,7 @@ @for (var groupIndex = 0; groupIndex < Groups.Count; groupIndex++) { var group = Groups[groupIndex]; - @* MudTabs renders the panel content later, when the loop variable is already past - the last index. *@ + @* MudTabs renders the panel content after the loop is over. *@ var isFirstGroup = groupIndex == 0; @if (isFirstGroup) diff --git a/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor.cs b/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor.cs index f75adfafc4..2b0c50a103 100644 --- a/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor.cs +++ b/modules/feature-management/src/Volo.Abp.FeatureManagement.Blazor.MudBlazor/Components/FeatureManagementModal.razor.cs @@ -98,8 +98,7 @@ public partial class FeatureManagementModal } _isVisible = true; - // The previous reference points to an element that is gone, and it would be taken for a - // bound container on the next render. + // The previous reference points to an element that is gone by now. _firstGroupContainer = default; _shouldFocusFirstGroup = Groups.Any(); _focusRenderCount = 0; @@ -126,8 +125,8 @@ public partial class FeatureManagementModal return; } - // The dialog provider renders the content in a later batch, so the container is not bound yet - // on the render that makes the dialog visible. Rendering again brings this method back. + // The dialog provider renders the content in a later batch, so rendering again is what brings + // this method back once the container is bound. if (_firstGroupContainer.Id.IsNullOrEmpty()) { if (_focusRenderCount++ < MaxFocusRenderCount)