From 6d16655c23f4f7da2efa41c95daeb8dcc9e40d9e Mon Sep 17 00:00:00 2001 From: Yunus Emre Kalkan Date: Wed, 18 Mar 2020 19:39:11 +0300 Subject: [PATCH] Fix: CLI update command replaces first character of NPM version with ^ resolves https://github.com/volosoft/volo/issues/1497 --- .../Abp/Cli/ProjectModification/NpmPackagesUpdater.cs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NpmPackagesUpdater.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NpmPackagesUpdater.cs index 91eaec48e7..263e94c377 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NpmPackagesUpdater.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NpmPackagesUpdater.cs @@ -99,26 +99,21 @@ namespace Volo.Abp.Cli.ProjectModification protected virtual async Task TryUpdatePackage(string file, JProperty package, bool includePreviews = false, bool switchToStable = false) { - var updated = false; var currentVersion = (string)package.Value; var version = await GetLatestVersion(package, currentVersion, includePreviews, switchToStable); - var versionWithPrefix = $"^{version}"; + var versionWithPrefix = $"~{version}"; if (versionWithPrefix == currentVersion) { return false; } - else - { - updated = true; - } package.Value.Replace(versionWithPrefix); Logger.LogInformation($"Updated {package.Name} to {version} in {file.Replace(Directory.GetCurrentDirectory(), "")}."); - return updated; + return true; } protected virtual async Task GetLatestVersion(JProperty package, string currentVersion,