From 737115e5a2d78a664fbc25a5b46bd4437696d75f Mon Sep 17 00:00:00 2001 From: Berkan Sasmaz Date: Tue, 4 Jun 2024 10:53:57 +0300 Subject: [PATCH] Remove unnecessary end-point and update proxies --- .../Admin/Comments/ICommentAdminAppService.cs | 2 - .../Admin/Comments/CommentAdminAppService.cs | 8 - .../CommentAdminClientProxy.Generated.cs | 5 - .../cms-kit-admin-generate-proxy.json | 23 --- .../Admin/Comments/CommentAdminController.cs | 7 - .../Pages/CmsKit/Comments/Details.cshtml | 2 +- .../Pages/CmsKit/Comments/Index.cshtml | 4 +- .../Pages/CmsKit/Comments/details.js | 21 +- .../Pages/CmsKit/Comments/index.js | 21 +- .../Shared/Components/Comments/default.js | 7 +- .../client-proxies/cms-kit-admin-proxy.js | 7 - .../client-proxies/cms-kit-common-proxy.js | 16 +- .../CmsKit/Localization/Resources/en.json | 2 - .../Shared/Components/Commenting/default.js | 2 +- .../wwwroot/client-proxies/cms-kit-proxy.js | 179 ++++++++++-------- 15 files changed, 133 insertions(+), 173 deletions(-) diff --git a/modules/cms-kit/src/Volo.CmsKit.Admin.Application.Contracts/Volo/CmsKit/Admin/Comments/ICommentAdminAppService.cs b/modules/cms-kit/src/Volo.CmsKit.Admin.Application.Contracts/Volo/CmsKit/Admin/Comments/ICommentAdminAppService.cs index 561d5d137e..8fd87a2e00 100644 --- a/modules/cms-kit/src/Volo.CmsKit.Admin.Application.Contracts/Volo/CmsKit/Admin/Comments/ICommentAdminAppService.cs +++ b/modules/cms-kit/src/Volo.CmsKit.Admin.Application.Contracts/Volo/CmsKit/Admin/Comments/ICommentAdminAppService.cs @@ -17,7 +17,5 @@ public interface ICommentAdminAppService : IApplicationService Task UpdateSettingsAsync(CommentSettingsDto input); - Task GetSettingsAsync(); - Task GetWaitingCountAsync(); } diff --git a/modules/cms-kit/src/Volo.CmsKit.Admin.Application/Volo/CmsKit/Admin/Comments/CommentAdminAppService.cs b/modules/cms-kit/src/Volo.CmsKit.Admin.Application/Volo/CmsKit/Admin/Comments/CommentAdminAppService.cs index 7a5277cf7b..07b17083c2 100644 --- a/modules/cms-kit/src/Volo.CmsKit.Admin.Application/Volo/CmsKit/Admin/Comments/CommentAdminAppService.cs +++ b/modules/cms-kit/src/Volo.CmsKit.Admin.Application/Volo/CmsKit/Admin/Comments/CommentAdminAppService.cs @@ -99,14 +99,6 @@ public class CommentAdminAppService : CmsKitAdminAppServiceBase, ICommentAdminAp await SettingManager.SetGlobalAsync(CmsKitSettings.Comments.RequireApprovement, input.CommentRequireApprovement.ToString()); } - [Authorize(CmsKitAdminPermissions.Comments.SettingManagement)] - public async Task GetSettingsAsync() - { - var isRequireApprovementEnabled = bool.Parse(await SettingManager.GetOrNullGlobalAsync(CmsKitSettings.Comments.RequireApprovement)); - - return new CommentSettingsDto {CommentRequireApprovement = isRequireApprovementEnabled}; - } - public async Task GetWaitingCountAsync() { return (int)await CommentRepository.GetCountAsync(commentApproveState: CommentApproveState.Waiting); diff --git a/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/Volo/CmsKit/Admin/Comments/CommentAdminClientProxy.Generated.cs b/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/Volo/CmsKit/Admin/Comments/CommentAdminClientProxy.Generated.cs index 458c88dfa5..845963c334 100644 --- a/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/Volo/CmsKit/Admin/Comments/CommentAdminClientProxy.Generated.cs +++ b/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/Volo/CmsKit/Admin/Comments/CommentAdminClientProxy.Generated.cs @@ -58,11 +58,6 @@ public partial class CommentAdminClientProxy : ClientProxyBase GetSettingsAsync() - { - return await RequestAsync(nameof(GetSettingsAsync)); - } - public virtual async Task GetWaitingCountAsync() { return await RequestAsync(nameof(GetWaitingCountAsync)); diff --git a/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/cms-kit-admin-generate-proxy.json b/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/cms-kit-admin-generate-proxy.json index ef2eef16d8..cf4bbd1034 100644 --- a/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/cms-kit-admin-generate-proxy.json +++ b/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi.Client/ClientProxies/cms-kit-admin-generate-proxy.json @@ -1310,14 +1310,6 @@ "typeSimple": "System.Void" } }, - { - "name": "GetSettingsAsync", - "parametersOnMethod": [], - "returnValue": { - "type": "Volo.CmsKit.Admin.Comments.CommentSettingsDto", - "typeSimple": "Volo.CmsKit.Admin.Comments.CommentSettingsDto" - } - }, { "name": "GetWaitingCountAsync", "parametersOnMethod": [], @@ -1643,21 +1635,6 @@ "allowAnonymous": false, "implementFrom": "Volo.CmsKit.Admin.Comments.ICommentAdminAppService" }, - "GetSettingsAsync": { - "uniqueName": "GetSettingsAsync", - "name": "GetSettingsAsync", - "httpMethod": "GET", - "url": "api/cms-kit-admin/comments/settings", - "supportedVersions": [], - "parametersOnMethod": [], - "parameters": [], - "returnValue": { - "type": "Volo.CmsKit.Admin.Comments.CommentSettingsDto", - "typeSimple": "Volo.CmsKit.Admin.Comments.CommentSettingsDto" - }, - "allowAnonymous": false, - "implementFrom": "Volo.CmsKit.Admin.Comments.ICommentAdminAppService" - }, "GetWaitingCountAsync": { "uniqueName": "GetWaitingCountAsync", "name": "GetWaitingCountAsync", diff --git a/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi/Volo/CmsKit/Admin/Comments/CommentAdminController.cs b/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi/Volo/CmsKit/Admin/Comments/CommentAdminController.cs index 924a128d34..9d9bbcd73f 100644 --- a/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi/Volo/CmsKit/Admin/Comments/CommentAdminController.cs +++ b/modules/cms-kit/src/Volo.CmsKit.Admin.HttpApi/Volo/CmsKit/Admin/Comments/CommentAdminController.cs @@ -62,13 +62,6 @@ public class CommentAdminController : CmsKitAdminController, ICommentAdminAppSer return CommentAdminAppService.UpdateSettingsAsync(input); } - [HttpGet] - [Route("settings")] - public Task GetSettingsAsync() - { - return CommentAdminAppService.GetSettingsAsync(); - } - [HttpGet] [Route("waiting-count")] public Task GetWaitingCountAsync() diff --git a/modules/cms-kit/src/Volo.CmsKit.Admin.Web/Pages/CmsKit/Comments/Details.cshtml b/modules/cms-kit/src/Volo.CmsKit.Admin.Web/Pages/CmsKit/Comments/Details.cshtml index c60619560f..a73475bac2 100644 --- a/modules/cms-kit/src/Volo.CmsKit.Admin.Web/Pages/CmsKit/Comments/Details.cshtml +++ b/modules/cms-kit/src/Volo.CmsKit.Admin.Web/Pages/CmsKit/Comments/Details.cshtml @@ -95,7 +95,7 @@ -
+