From 73782c1408389289d17123e282f4753cf2183661 Mon Sep 17 00:00:00 2001
From: Galip Tolga Erdem <galiperdem@gmail.com>
Date: Mon, 13 Jan 2020 12:35:00 +0300
Subject: [PATCH] Reverted SaveAsync on IAuditLgSaveHandle instead added
 AddException method.

---
 .../Auditing/AbpAuditingMiddleware.cs           |  2 +-
 .../Volo/Abp/Auditing/AuditingManager.cs        | 17 +++++++----------
 .../Volo/Abp/Auditing/IAuditLogSaveHandle.cs    |  3 ++-
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/framework/src/Volo.Abp.AspNetCore/Volo/Abp/AspNetCore/Auditing/AbpAuditingMiddleware.cs b/framework/src/Volo.Abp.AspNetCore/Volo/Abp/AspNetCore/Auditing/AbpAuditingMiddleware.cs
index b651274ed4..f2929e3f5a 100644
--- a/framework/src/Volo.Abp.AspNetCore/Volo/Abp/AspNetCore/Auditing/AbpAuditingMiddleware.cs
+++ b/framework/src/Volo.Abp.AspNetCore/Volo/Abp/AspNetCore/Auditing/AbpAuditingMiddleware.cs
@@ -42,7 +42,7 @@ namespace Volo.Abp.AspNetCore.Auditing
                 }
                 catch (Exception ex)
                 {
-                    await scope.SaveAsync(ex).ConfigureAwait(false);
+                    scope.AddException(ex);
                 }
                 finally
                 {
diff --git a/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/AuditingManager.cs b/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/AuditingManager.cs
index 1d3b912311..f2980d1cf5 100644
--- a/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/AuditingManager.cs
+++ b/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/AuditingManager.cs
@@ -150,16 +150,13 @@ namespace Volo.Abp.Auditing
                 StopWatch = stopWatch;
             }
 
-            public async Task SaveAsync(Exception exception = null)
-            {
-                if (exception != null)
-                {
-                    this.AuditLog.Exceptions.Add(exception);
-                }
-                else
-                {
-                    await _auditingManager.SaveAsync(this).ConfigureAwait(false);
-                }
+            public async Task SaveAsync()
+            {
+                    await _auditingManager.SaveAsync(this).ConfigureAwait(false);
+            }
+            public void AddException(Exception exception)
+            {
+                this.AuditLog.Exceptions.Add(exception);
             }
 
             public void Dispose()
diff --git a/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/IAuditLogSaveHandle.cs b/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/IAuditLogSaveHandle.cs
index 6e48f3525c..a549dcb755 100644
--- a/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/IAuditLogSaveHandle.cs
+++ b/framework/src/Volo.Abp.Auditing/Volo/Abp/Auditing/IAuditLogSaveHandle.cs
@@ -5,6 +5,7 @@ namespace Volo.Abp.Auditing
 {
     public interface IAuditLogSaveHandle : IDisposable
     {
-        Task SaveAsync(Exception exception = null);
+        Task SaveAsync();
+        void AddException(Exception exception);
     }
 }
\ No newline at end of file