Browse Source

Merge pull request #24497 from abpframework/fix/refactor-memory-token-storage-service

Angular - remove logs from memory token storage service
pull/24575/head
sumeyye 1 month ago
committed by GitHub
parent
commit
799895bc14
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 16
      npm/ng-packs/packages/oauth/src/lib/services/memory-token-storage.service.ts

16
npm/ng-packs/packages/oauth/src/lib/services/memory-token-storage.service.ts

@ -36,12 +36,9 @@ export class MemoryTokenStorageService implements OAuthStorage {
} }
private initializeStorage(): void { private initializeStorage(): void {
console.log('Initialize Storage -->>', typeof SharedWorker !== 'undefined');
// @ts-ignore // @ts-ignore
if (typeof SharedWorker !== 'undefined') { if (typeof SharedWorker !== 'undefined') {
try { try {
console.log('Shared worker is loaded');
console.log('refresh view');
// Create worker from data URL to avoid path resolution issues in consuming apps // Create worker from data URL to avoid path resolution issues in consuming apps
// Data URLs are deterministic - same content produces same URL across all tabs // Data URLs are deterministic - same content produces same URL across all tabs
if (!MemoryTokenStorageService.workerUrl) { if (!MemoryTokenStorageService.workerUrl) {
@ -51,7 +48,6 @@ export class MemoryTokenStorageService implements OAuthStorage {
this.worker = new SharedWorker(MemoryTokenStorageService.workerUrl, { this.worker = new SharedWorker(MemoryTokenStorageService.workerUrl, {
name: 'oauth-token-storage', name: 'oauth-token-storage',
}); });
console.log('loaded worker -->>', this.worker);
this.port = this.worker.port; this.port = this.worker.port;
this.port.start(); this.port.start();
this.useSharedWorker = true; this.useSharedWorker = true;
@ -85,7 +81,6 @@ export class MemoryTokenStorageService implements OAuthStorage {
this.port?.postMessage({ action: 'get', key }); this.port?.postMessage({ action: 'get', key });
}); });
} catch (error) { } catch (error) {
console.log(error);
this.useSharedWorker = false; this.useSharedWorker = false;
} }
} else { } else {
@ -140,7 +135,7 @@ export class MemoryTokenStorageService implements OAuthStorage {
try { try {
this.port.postMessage({ action: 'disconnect' }); this.port.postMessage({ action: 'disconnect' });
} catch (error) { } catch (error) {
console.log('Error disconnecting port:', error); //
} }
} }
} }
@ -181,28 +176,22 @@ function broadcastToOtherPorts(senderPort, message) {
try { try {
p.postMessage(message); p.postMessage(message);
} catch (error) { } catch (error) {
console.log('Dead port detected during broadcast, removing...');
deadPorts.push(p); deadPorts.push(p);
} }
} }
}); });
deadPorts.forEach(p => ports.delete(p)); deadPorts.forEach(p => ports.delete(p));
if (deadPorts.length > 0) {
console.log('Cleaned up', deadPorts.length, 'dead ports. Total ports:', ports.size);
}
} }
function removePort(port) { function removePort(port) {
if (ports.has(port)) { if (ports.has(port)) {
ports.delete(port); ports.delete(port);
console.log('Port disconnected. Total ports:', ports.size);
} }
} }
self.onconnect = (event) => { self.onconnect = (event) => {
const port = event.ports[0]; const port = event.ports[0];
ports.add(port); ports.add(port);
console.log('Port connected. Total ports:', ports.size);
port.addEventListener('messageerror', () => { port.addEventListener('messageerror', () => {
removePort(port); removePort(port);
@ -239,12 +228,11 @@ self.onconnect = (event) => {
break; break;
case 'disconnect': case 'disconnect':
console.log('Port requested disconnect');
removePort(port); removePort(port);
break; break;
default: default:
console.warn('Unknown action:', action); //
} }
}; };

Loading…
Cancel
Save