From 7bc3cad009a491d6764fd2f3bef18bec84d98130 Mon Sep 17 00:00:00 2001 From: maliming Date: Fri, 5 Jul 2019 20:46:14 +0800 Subject: [PATCH] Remove Todo. --- .../Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs | 2 +- .../Abp/Cli/ProjectBuilding/Analyticses/CliAnalyticsCollect.cs | 1 - .../Volo/Abp/Cli/ProjectBuilding/ProjectBuilder.cs | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs index ea570026a7..f0b00b913b 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/UpdateCommand.cs @@ -52,7 +52,7 @@ namespace Volo.Abp.Cli.Commands { Tool = _options.ToolName, Command = commandLineArgs.Command, - Options = _jsonSerializer.Serialize(options) //TODO: JSON or comma separated string? + Options = _jsonSerializer.Serialize(options) }); } diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Analyticses/CliAnalyticsCollect.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Analyticses/CliAnalyticsCollect.cs index e85f973eb9..6598c9fb31 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Analyticses/CliAnalyticsCollect.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/Analyticses/CliAnalyticsCollect.cs @@ -36,7 +36,6 @@ namespace Volo.Abp.Cli.ProjectBuilding.Analyticses _cancellationTokenProvider.Token ); - // TODO: Do not output logs, keep silent? if (!responseMessage.IsSuccessStatusCode) { _logger.LogInformation("Remote server returns error! HTTP status code: " + diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/ProjectBuilder.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/ProjectBuilder.cs index eff593baf6..49d7648e22 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/ProjectBuilder.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectBuilding/ProjectBuilder.cs @@ -83,7 +83,7 @@ namespace Volo.Abp.Cli.ProjectBuilding Command = args.ExtraProperties.ContainsKey(CliConsts.Command) ? args.ExtraProperties[CliConsts.Command] : "", DatabaseProvider = args.DatabaseProvider.ToProviderName(), IsTiered = args.ExtraProperties.ContainsKey("tiered"), - Options = JsonSerializer.Serialize(options), //TODO: JSON or comma separated string? + Options = JsonSerializer.Serialize(options), ProjectName = args.SolutionName.FullName, TemplateName = args.TemplateName, TemplateVersion = templateFile.Version