From 81193a261b84e4bb97b715011a9d76b70e4da861 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= Date: Thu, 21 May 2020 00:44:57 +0300 Subject: [PATCH] Clean unused code and format code. --- .../Quartz/QuartzBackgroundJobManager.cs | 12 ++++++------ .../DemoAppHangfireModule.cs | 9 --------- .../DemoAppQuartzModule.cs | 15 ++------------- .../DemoAppRabbitMqModule.cs | 13 ++----------- 4 files changed, 10 insertions(+), 39 deletions(-) diff --git a/framework/src/Volo.Abp.BackgroundJobs.Quartz/Volo/Abp/BackgroundJobs/Quartz/QuartzBackgroundJobManager.cs b/framework/src/Volo.Abp.BackgroundJobs.Quartz/Volo/Abp/BackgroundJobs/Quartz/QuartzBackgroundJobManager.cs index 173d05e29b..83b74297a5 100644 --- a/framework/src/Volo.Abp.BackgroundJobs.Quartz/Volo/Abp/BackgroundJobs/Quartz/QuartzBackgroundJobManager.cs +++ b/framework/src/Volo.Abp.BackgroundJobs.Quartz/Volo/Abp/BackgroundJobs/Quartz/QuartzBackgroundJobManager.cs @@ -8,15 +8,15 @@ namespace Volo.Abp.BackgroundJobs.Quartz { [Dependency(ReplaceServices = true)] public class QuartzBackgroundJobManager : IBackgroundJobManager, ITransientDependency - { + { public const string JobDataPrefix = "Abp"; public const string RetryIndex = "RetryIndex"; - + protected IScheduler Scheduler { get; } + protected AbpBackgroundJobQuartzOptions Options { get; } - - - public QuartzBackgroundJobManager(IScheduler scheduler,IOptions options) + + public QuartzBackgroundJobManager(IScheduler scheduler, IOptions options) { Scheduler = scheduler; Options = options.Value; @@ -38,7 +38,7 @@ namespace Volo.Abp.BackgroundJobs.Quartz {JobDataPrefix+ nameof(Options.RetryIntervalMillisecond), retryIntervalMillisecond}, {JobDataPrefix+ RetryIndex, 0} }; - + var jobDetail = JobBuilder.Create>().RequestRecovery().SetJobData(jobDataMap).Build(); var trigger = !delay.HasValue ? TriggerBuilder.Create().StartNow().Build() : TriggerBuilder.Create().StartAt(new DateTimeOffset(DateTime.Now.Add(delay.Value))).Build(); await Scheduler.ScheduleJob(jobDetail, trigger); diff --git a/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.HangFire/DemoAppHangfireModule.cs b/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.HangFire/DemoAppHangfireModule.cs index ed3639bce0..0a405d4767 100644 --- a/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.HangFire/DemoAppHangfireModule.cs +++ b/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.HangFire/DemoAppHangfireModule.cs @@ -24,14 +24,5 @@ namespace Volo.Abp.BackgroundJobs.DemoApp.HangFire hangfireConfiguration.UseSqlServerStorage(configuration.GetConnectionString("Default")); }); } - - public override void OnApplicationInitialization(ApplicationInitializationContext context) - { - //TODO: Configure console logging - //context - // .ServiceProvider - // .GetRequiredService() - // .AddConsole(LogLevel.Debug); - } } } diff --git a/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.Quartz/DemoAppQuartzModule.cs b/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.Quartz/DemoAppQuartzModule.cs index 76c8815a9f..d5aa618952 100644 --- a/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.Quartz/DemoAppQuartzModule.cs +++ b/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.Quartz/DemoAppQuartzModule.cs @@ -1,11 +1,7 @@ -using System.Collections.Specialized; -using Microsoft.Extensions.Configuration; -using Microsoft.Extensions.DependencyInjection; -using Volo.Abp.Autofac; +using Volo.Abp.Autofac; using Volo.Abp.BackgroundJobs.DemoApp.Shared; using Volo.Abp.BackgroundJobs.Quartz; using Volo.Abp.Modularity; -using Volo.Abp.Quartz; namespace Volo.Abp.BackgroundJobs.DemoApp.Quartz { @@ -16,13 +12,6 @@ namespace Volo.Abp.BackgroundJobs.DemoApp.Quartz )] public class DemoAppQuartzModule : AbpModule { - public override void OnApplicationInitialization(ApplicationInitializationContext context) - { - //TODO: Configure console logging - //context - // .ServiceProvider - // .GetRequiredService() - // .AddConsole(LogLevel.Debug); - } + } } diff --git a/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.RabbitMq/DemoAppRabbitMqModule.cs b/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.RabbitMq/DemoAppRabbitMqModule.cs index 416bb29a96..8c2e09d37e 100644 --- a/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.RabbitMq/DemoAppRabbitMqModule.cs +++ b/modules/background-jobs/app/Volo.Abp.BackgroundJobs.DemoApp.RabbitMq/DemoAppRabbitMqModule.cs @@ -1,6 +1,4 @@ -using Microsoft.Extensions.DependencyInjection; -using Microsoft.Extensions.Logging; -using Volo.Abp.Autofac; +using Volo.Abp.Autofac; using Volo.Abp.BackgroundJobs.DemoApp.Shared; using Volo.Abp.BackgroundJobs.RabbitMQ; using Volo.Abp.Modularity; @@ -14,13 +12,6 @@ namespace Volo.Abp.BackgroundJobs.DemoApp.RabbitMq )] public class DemoAppRabbitMqModule : AbpModule { - public override void OnApplicationInitialization(ApplicationInitializationContext context) - { - //TODO: Configure console logging - //context - // .ServiceProvider - // .GetRequiredService() - // .AddConsole(LogLevel.Debug); - } + } }