From 8377f2d6ae8bb5bf5d65e8d7db7974fb4e323dd7 Mon Sep 17 00:00:00 2001
From: Ahmed Fwela <ahmednfwela@bdaya-dev.com>
Date: Mon, 20 Nov 2023 16:32:04 +0200
Subject: [PATCH] Remove IEntityDto restrictions from CrudApplicationService

---
 .../Volo/Abp/Application/Services/CrudAppService.cs       | 6 ------
 .../Volo/Abp/Application/Services/ReadOnlyAppService.cs   | 8 ++------
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/CrudAppService.cs b/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/CrudAppService.cs
index d8ccce3b73..672d85a2be 100644
--- a/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/CrudAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/CrudAppService.cs
@@ -11,7 +11,6 @@ namespace Volo.Abp.Application.Services;
 public abstract class CrudAppService<TEntity, TEntityDto, TKey>
     : CrudAppService<TEntity, TEntityDto, TKey, PagedAndSortedResultRequestDto>
     where TEntity : class, IEntity<TKey>
-    where TEntityDto : IEntityDto<TKey>
 {
     protected CrudAppService(IRepository<TEntity, TKey> repository)
         : base(repository)
@@ -23,7 +22,6 @@ public abstract class CrudAppService<TEntity, TEntityDto, TKey>
 public abstract class CrudAppService<TEntity, TEntityDto, TKey, TGetListInput>
     : CrudAppService<TEntity, TEntityDto, TKey, TGetListInput, TEntityDto>
     where TEntity : class, IEntity<TKey>
-    where TEntityDto : IEntityDto<TKey>
 {
     protected CrudAppService(IRepository<TEntity, TKey> repository)
         : base(repository)
@@ -35,7 +33,6 @@ public abstract class CrudAppService<TEntity, TEntityDto, TKey, TGetListInput>
 public abstract class CrudAppService<TEntity, TEntityDto, TKey, TGetListInput, TCreateInput>
     : CrudAppService<TEntity, TEntityDto, TKey, TGetListInput, TCreateInput, TCreateInput>
     where TEntity : class, IEntity<TKey>
-    where TEntityDto : IEntityDto<TKey>
 {
     protected CrudAppService(IRepository<TEntity, TKey> repository)
         : base(repository)
@@ -47,7 +44,6 @@ public abstract class CrudAppService<TEntity, TEntityDto, TKey, TGetListInput, T
 public abstract class CrudAppService<TEntity, TEntityDto, TKey, TGetListInput, TCreateInput, TUpdateInput>
     : CrudAppService<TEntity, TEntityDto, TEntityDto, TKey, TGetListInput, TCreateInput, TUpdateInput>
     where TEntity : class, IEntity<TKey>
-    where TEntityDto : IEntityDto<TKey>
 {
     protected CrudAppService(IRepository<TEntity, TKey> repository)
         : base(repository)
@@ -69,8 +65,6 @@ public abstract class CrudAppService<TEntity, TEntityDto, TKey, TGetListInput, T
 public abstract class CrudAppService<TEntity, TGetOutputDto, TGetListOutputDto, TKey, TGetListInput, TCreateInput, TUpdateInput>
     : AbstractKeyCrudAppService<TEntity, TGetOutputDto, TGetListOutputDto, TKey, TGetListInput, TCreateInput, TUpdateInput>
     where TEntity : class, IEntity<TKey>
-    where TGetOutputDto : IEntityDto<TKey>
-    where TGetListOutputDto : IEntityDto<TKey>
 {
     protected new IRepository<TEntity, TKey> Repository { get; }
 
diff --git a/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/ReadOnlyAppService.cs b/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/ReadOnlyAppService.cs
index b81455e1bb..abc8299aef 100644
--- a/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/ReadOnlyAppService.cs
+++ b/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/ReadOnlyAppService.cs
@@ -11,7 +11,6 @@ namespace Volo.Abp.Application.Services;
 public abstract class ReadOnlyAppService<TEntity, TEntityDto, TKey>
     : ReadOnlyAppService<TEntity, TEntityDto, TEntityDto, TKey, PagedAndSortedResultRequestDto>
     where TEntity : class, IEntity<TKey>
-    where TEntityDto : IEntityDto<TKey>
 {
     protected ReadOnlyAppService(IReadOnlyRepository<TEntity, TKey> repository)
         : base(repository)
@@ -22,8 +21,7 @@ public abstract class ReadOnlyAppService<TEntity, TEntityDto, TKey>
 
 public abstract class ReadOnlyAppService<TEntity, TEntityDto, TKey, TGetListInput>
     : ReadOnlyAppService<TEntity, TEntityDto, TEntityDto, TKey, TGetListInput>
-    where TEntity : class, IEntity<TKey>
-    where TEntityDto : IEntityDto<TKey>
+    where TEntity : class, IEntity<TKey>    
 {
     protected ReadOnlyAppService(IReadOnlyRepository<TEntity, TKey> repository)
         : base(repository)
@@ -34,9 +32,7 @@ public abstract class ReadOnlyAppService<TEntity, TEntityDto, TKey, TGetListInpu
 
 public abstract class ReadOnlyAppService<TEntity, TGetOutputDto, TGetListOutputDto, TKey, TGetListInput>
     : AbstractKeyReadOnlyAppService<TEntity, TGetOutputDto, TGetListOutputDto, TKey, TGetListInput>
-    where TEntity : class, IEntity<TKey>
-    where TGetOutputDto : IEntityDto<TKey>
-    where TGetListOutputDto : IEntityDto<TKey>
+    where TEntity : class, IEntity<TKey>    
 {
     protected IReadOnlyRepository<TEntity, TKey> Repository { get; }