From 89df1e68f72b9d2093cc4fdfb6b3b8c5be964d4d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sinan=20=C3=96zt=C3=BCrk?= <sinanozturk997@gmail.com>
Date: Fri, 16 Feb 2024 23:30:35 +0300
Subject: [PATCH] add test to remember-me.service and fix return value in
 service

---
 .../src/lib/services/remember-me.service.ts   |  2 +-
 .../src/lib/tests/remember-me.service.spec.ts | 71 +++++++++++++++++++
 2 files changed, 72 insertions(+), 1 deletion(-)
 create mode 100644 npm/ng-packs/packages/oauth/src/lib/tests/remember-me.service.spec.ts

diff --git a/npm/ng-packs/packages/oauth/src/lib/services/remember-me.service.ts b/npm/ng-packs/packages/oauth/src/lib/services/remember-me.service.ts
index 84d40d982a..ed938c5107 100644
--- a/npm/ng-packs/packages/oauth/src/lib/services/remember-me.service.ts
+++ b/npm/ng-packs/packages/oauth/src/lib/services/remember-me.service.ts
@@ -17,7 +17,7 @@ export class RememberMeService {
   }
 
   get() {
-    return Boolean(JSON.parse(this.localStorageService.getItem(this.#rememberMe)));
+    return Boolean(JSON.parse(this.localStorageService.getItem(this.#rememberMe) || 'false'));
   }
 
   getFromToken(accessToken: string) {
diff --git a/npm/ng-packs/packages/oauth/src/lib/tests/remember-me.service.spec.ts b/npm/ng-packs/packages/oauth/src/lib/tests/remember-me.service.spec.ts
new file mode 100644
index 0000000000..0ef7116e92
--- /dev/null
+++ b/npm/ng-packs/packages/oauth/src/lib/tests/remember-me.service.spec.ts
@@ -0,0 +1,71 @@
+import { SpectatorService, SpyObject, createServiceFactory } from "@ngneat/spectator/jest";
+import { RememberMeService } from "../services/remember-me.service";
+import { AbpLocalStorageService } from "@abp/ng.core";
+
+
+
+describe('RememberMeService', () => {
+  const key = 'remember_me';
+  let spectator: SpectatorService<RememberMeService>;
+  let rememberMeService: RememberMeService;
+  let abpLocalStorageService: SpyObject<AbpLocalStorageService>;
+
+  const createService = createServiceFactory({
+    service: RememberMeService,
+    mocks: [AbpLocalStorageService]
+  });
+
+
+  beforeEach(() => {
+    spectator = createService();
+    rememberMeService = spectator.inject(RememberMeService);
+    abpLocalStorageService = spectator.inject(AbpLocalStorageService);
+  });
+
+  it('should be created', () => {
+    expect(1).toBe(1);
+    expect(rememberMeService).toBeTruthy();
+    expect(abpLocalStorageService).toBeTruthy();
+  });
+
+  it('should set remember me', () => {
+    rememberMeService.set(true);
+    expect(abpLocalStorageService.setItem).toHaveBeenCalledWith(key, 'true');
+    expect(abpLocalStorageService.setItem).toHaveBeenCalledTimes(1);
+  });
+
+  it('should remove remember me', () => {
+    rememberMeService.remove();
+    expect(abpLocalStorageService.removeItem).toHaveBeenCalledWith(key);
+    expect(abpLocalStorageService.removeItem).toBeCalledTimes(1);
+  });
+
+  it('if notting has ben setted, it should return false value', () => {
+    expect(rememberMeService.get()).toBe(false);
+  });
+
+  it('should return true value', () => {
+    abpLocalStorageService.getItem.mockReturnValueOnce('true');
+    expect(rememberMeService.get()).toBe(true);
+  });
+
+  it('should return false value', () => {
+    abpLocalStorageService.getItem.mockReturnValueOnce('false');
+    expect(rememberMeService.get()).toBe(false);
+  });
+
+  it('should return true when parsed token is setted to true', () => {
+    const data = { "remember_me": "True" };
+    const base64_encoded = btoa(JSON.stringify(data));
+    const tokenWithValueTrue = "random." + base64_encoded + ".random";
+    expect(rememberMeService.getFromToken(tokenWithValueTrue)).toBe(true);
+  });
+
+  it('should return false when value is not setted(undefined)', () => {
+    const data = {};
+    const base64_encoded = btoa(JSON.stringify(data));
+    const tokenWithValueTrue = "random." + base64_encoded + ".random";
+    expect(rememberMeService.getFromToken(tokenWithValueTrue)).toBe(false);
+  });
+
+});
\ No newline at end of file