From 91b5b74b95bcb2807a15a5365e92c07eed9b34ae Mon Sep 17 00:00:00 2001 From: Arman Ozak Date: Fri, 25 Dec 2020 18:22:40 +0300 Subject: [PATCH] remove MockLocalizationPipe from core testing package --- .../core/testing/src/lib/core-testing.module.ts | 17 ++--------------- .../core/testing/src/lib/pipes/index.ts | 1 - .../src/lib/pipes/mock-localization.pipe.ts | 12 ------------ .../packages/core/testing/src/public-api.ts | 1 - 4 files changed, 2 insertions(+), 29 deletions(-) delete mode 100644 npm/ng-packs/packages/core/testing/src/lib/pipes/index.ts delete mode 100644 npm/ng-packs/packages/core/testing/src/lib/pipes/mock-localization.pipe.ts diff --git a/npm/ng-packs/packages/core/testing/src/lib/core-testing.module.ts b/npm/ng-packs/packages/core/testing/src/lib/core-testing.module.ts index 9a7fc3eec0..214a49ebc9 100644 --- a/npm/ng-packs/packages/core/testing/src/lib/core-testing.module.ts +++ b/npm/ng-packs/packages/core/testing/src/lib/core-testing.module.ts @@ -1,16 +1,8 @@ -import { - ABP, - BaseCoreModule, - coreOptionsFactory, - CORE_OPTIONS, - LocalizationPipe, - RestService, -} from '@abp/ng.core'; +import { ABP, BaseCoreModule, coreOptionsFactory, CORE_OPTIONS, RestService } from '@abp/ng.core'; import { APP_BASE_HREF } from '@angular/common'; import { ModuleWithProviders, NgModule } from '@angular/core'; import { provideRoutes } from '@angular/router'; import { RouterTestingModule } from '@angular/router/testing'; -import { MockLocalizationPipe } from './pipes/mock-localization.pipe'; import { MockRestService } from './services/mock-rest.service'; /** @@ -18,9 +10,8 @@ import { MockRestService } from './services/mock-rest.service'; * and it provides mock alternatives */ @NgModule({ - exports: [RouterTestingModule, BaseCoreModule, MockLocalizationPipe], + exports: [RouterTestingModule, BaseCoreModule], imports: [RouterTestingModule, BaseCoreModule], - declarations: [MockLocalizationPipe], }) export class CoreTestingModule { static withConfig( @@ -39,10 +30,6 @@ export class CoreTestingModule { useFactory: coreOptionsFactory, deps: ['CORE_OPTIONS'], }, - { - provide: LocalizationPipe, - useClass: MockLocalizationPipe, - }, { provide: RestService, useClass: MockRestService, diff --git a/npm/ng-packs/packages/core/testing/src/lib/pipes/index.ts b/npm/ng-packs/packages/core/testing/src/lib/pipes/index.ts deleted file mode 100644 index 60bb9b7dce..0000000000 --- a/npm/ng-packs/packages/core/testing/src/lib/pipes/index.ts +++ /dev/null @@ -1 +0,0 @@ -export * from './mock-localization.pipe'; diff --git a/npm/ng-packs/packages/core/testing/src/lib/pipes/mock-localization.pipe.ts b/npm/ng-packs/packages/core/testing/src/lib/pipes/mock-localization.pipe.ts deleted file mode 100644 index 302173cb0f..0000000000 --- a/npm/ng-packs/packages/core/testing/src/lib/pipes/mock-localization.pipe.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { Config } from '@abp/ng.core'; -import { Injectable, Pipe, PipeTransform } from '@angular/core'; - -@Injectable() -@Pipe({ - name: 'abpLocalization', -}) -export class MockLocalizationPipe implements PipeTransform { - transform(value: string | Config.LocalizationWithDefault = '', ..._: string[]) { - return typeof value === 'string' ? value : value.defaultValue; - } -} diff --git a/npm/ng-packs/packages/core/testing/src/public-api.ts b/npm/ng-packs/packages/core/testing/src/public-api.ts index 8028a99aac..3b48853680 100644 --- a/npm/ng-packs/packages/core/testing/src/public-api.ts +++ b/npm/ng-packs/packages/core/testing/src/public-api.ts @@ -1,2 +1 @@ export * from './lib/core-testing.module'; -export * from './lib/pipes';