From 922af8e558462586bfa74bedaaa48cff10335942 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= Date: Tue, 9 Jul 2019 15:52:08 +0300 Subject: [PATCH] Remove EmailSenderBase.SendEmail --- .../Volo/Abp/Emailing/EmailSenderBase.cs | 6 ------ .../Volo/Abp/Emailing/NullEmailSender.cs | 7 ------- .../Volo/Abp/Emailing/Smtp/SmtpEmailSender.cs | 8 -------- 3 files changed, 21 deletions(-) diff --git a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/EmailSenderBase.cs b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/EmailSenderBase.cs index a3b085a27c..f6588de9fb 100644 --- a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/EmailSenderBase.cs +++ b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/EmailSenderBase.cs @@ -75,12 +75,6 @@ namespace Volo.Abp.Emailing /// Mail to be sent protected abstract Task SendEmailAsync(MailMessage mail); - /// - /// Should implement this method to send email in derived classes. - /// - /// Mail to be sent - protected abstract void SendEmail(MailMessage mail); - /// /// Normalizes given email. /// Fills if it's not filled before. diff --git a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/NullEmailSender.cs b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/NullEmailSender.cs index 1a2949c148..f0f7238484 100644 --- a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/NullEmailSender.cs +++ b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/NullEmailSender.cs @@ -31,13 +31,6 @@ namespace Volo.Abp.Emailing return Task.FromResult(0); } - protected override void SendEmail(MailMessage mail) - { - Logger.LogWarning("USING NullEmailSender!"); - Logger.LogWarning("SendEmail:"); - LogEmail(mail); - } - private void LogEmail(MailMessage mail) { Logger.LogDebug(mail.To.ToString()); diff --git a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/Smtp/SmtpEmailSender.cs b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/Smtp/SmtpEmailSender.cs index f7f431eaca..f97fd57b18 100644 --- a/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/Smtp/SmtpEmailSender.cs +++ b/framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/Smtp/SmtpEmailSender.cs @@ -75,13 +75,5 @@ namespace Volo.Abp.Emailing.Smtp await smtpClient.SendMailAsync(mail); } } - - protected override void SendEmail(MailMessage mail) - { - using (var smtpClient = AsyncHelper.RunSync(BuildClientAsync)) - { - smtpClient.Send(mail); - } - } } }