From 956d6b68a4ddb1d233b3778314358983c3ea7113 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= <hi_kalkan@yahoo.com>
Date: Thu, 21 May 2020 00:44:16 +0300
Subject: [PATCH] #3382 Throw exception instead of warning if background job
 execution was disabled but still trying to execute.

---
 .../Hangfire/HangfireJobExecutionAdapter.cs          | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/framework/src/Volo.Abp.BackgroundJobs.HangFire/Volo/Abp/BackgroundJobs/Hangfire/HangfireJobExecutionAdapter.cs b/framework/src/Volo.Abp.BackgroundJobs.HangFire/Volo/Abp/BackgroundJobs/Hangfire/HangfireJobExecutionAdapter.cs
index 41398b5bb6..9c0acf98d9 100644
--- a/framework/src/Volo.Abp.BackgroundJobs.HangFire/Volo/Abp/BackgroundJobs/Hangfire/HangfireJobExecutionAdapter.cs
+++ b/framework/src/Volo.Abp.BackgroundJobs.HangFire/Volo/Abp/BackgroundJobs/Hangfire/HangfireJobExecutionAdapter.cs
@@ -8,8 +8,6 @@ namespace Volo.Abp.BackgroundJobs.Hangfire
 {
     public class HangfireJobExecutionAdapter<TArgs>
     {
-        public ILogger<HangfireJobExecutionAdapter<TArgs>> Logger { get; set; }
-        
         protected AbpBackgroundJobOptions Options { get; }
         protected IServiceScopeFactory ServiceScopeFactory { get; }
         protected IBackgroundJobExecuter JobExecuter { get; }
@@ -22,15 +20,19 @@ namespace Volo.Abp.BackgroundJobs.Hangfire
             JobExecuter = jobExecuter;
             ServiceScopeFactory = serviceScopeFactory;
             Options = options.Value;
-            Logger = NullLogger<HangfireJobExecutionAdapter<TArgs>>.Instance;
         }
 
         public void Execute(TArgs args)
         {
             if (!Options.IsJobExecutionEnabled)
             {
-                Logger.LogWarning("Background jobs system is disabled");
-                return;
+                throw new AbpException(
+                    "Background job execution is disabled. " +
+                    "This method should not be called! " +
+                    "If you want to enable the background job execution, " +
+                    $"set {nameof(AbpBackgroundJobOptions)}.{nameof(AbpBackgroundJobOptions.IsJobExecutionEnabled)} to true! " +
+                    "If you've intentionally disabled job execution and this seems a bug, please report it."
+                );
             }
 
             using (var scope = ServiceScopeFactory.CreateScope())