Browse Source

Remove IBlobProvider.GetAsync

pull/4105/head
Halil İbrahim Kalkan 6 years ago
parent
commit
96491312d0
  1. 10
      framework/src/Volo.Abp.BlobStoring/Volo/Abp/BlobStoring/BlobContainer.cs
  2. 12
      framework/src/Volo.Abp.BlobStoring/Volo/Abp/BlobStoring/BlobProviderBase.cs
  3. 2
      framework/src/Volo.Abp.BlobStoring/Volo/Abp/BlobStoring/IBlobProvider.cs

10
framework/src/Volo.Abp.BlobStoring/Volo/Abp/BlobStoring/BlobContainer.cs

@ -151,7 +151,7 @@ namespace Volo.Abp.BlobStoring
string name,
CancellationToken cancellationToken = default)
{
return Provider.GetAsync(
var stream = Provider.GetOrNullAsync(
new BlobProviderGetArgs(
ContainerName,
Configuration,
@ -160,6 +160,14 @@ namespace Volo.Abp.BlobStoring
CancellationTokenProvider.FallbackToProvider(cancellationToken)
)
);
if (stream == null)
{
//TODO: Consider to throw some type of "not found" exception and handle on the HTTP status side
throw new AbpException($"Could not found the requested BLOB '{name}' in the container '{ContainerName}'!");
}
return stream;
}
public virtual Task<Stream> GetOrNullAsync(

12
framework/src/Volo.Abp.BlobStoring/Volo/Abp/BlobStoring/BlobProviderBase.cs

@ -11,18 +11,6 @@ namespace Volo.Abp.BlobStoring
public abstract Task<bool> ExistsAsync(BlobProviderExistsArgs args);
public virtual async Task<Stream> GetAsync(BlobProviderGetArgs args)
{
var result = await GetOrNullAsync(args);
if (result == null)
{
//TODO: Consider to throw some type of "not found" exception and handle on the HTTP status side
throw new AbpException($"Could not found the requested BLOB '{args.BlobName}' in the container '{args.ContainerName}'!");
}
return result;
}
public abstract Task<Stream> GetOrNullAsync(BlobProviderGetArgs args);
}
}

2
framework/src/Volo.Abp.BlobStoring/Volo/Abp/BlobStoring/IBlobProvider.cs

@ -12,8 +12,6 @@ namespace Volo.Abp.BlobStoring
Task<bool> ExistsAsync(BlobProviderExistsArgs args);
Task<Stream> GetAsync(BlobProviderGetArgs args);
Task<Stream> GetOrNullAsync(BlobProviderGetArgs args);
}
}
Loading…
Cancel
Save