Browse Source

Don't dispose AbpExceptionHandlingLogger

pull/5791/head
Halil İbrahim Kalkan 6 years ago
parent
commit
9b931d0b54
  1. 11
      framework/src/Volo.Abp.AspNetCore.Components.WebAssembly/Volo/Abp/AspNetCore/Components/WebAssembly/ExceptionHandling/AbpExceptionHandlingLogger.cs
  2. 2
      framework/src/Volo.Abp.AspNetCore.Components.WebAssembly/Volo/Abp/AspNetCore/Components/WebAssembly/ExceptionHandling/AbpExceptionHandlingLoggerProvider.cs

11
framework/src/Volo.Abp.AspNetCore.Components.WebAssembly/Volo/Abp/AspNetCore/Components/WebAssembly/ExceptionHandling/AbpExceptionHandlingLogger.cs

@ -4,10 +4,9 @@ using Microsoft.Extensions.Logging;
namespace Volo.Abp.AspNetCore.Components.WebAssembly.ExceptionHandling namespace Volo.Abp.AspNetCore.Components.WebAssembly.ExceptionHandling
{ {
public class AbpExceptionHandlingLogger : ILogger, IDisposable public class AbpExceptionHandlingLogger : ILogger
{ {
private readonly IServiceCollection _serviceCollection; private readonly IServiceCollection _serviceCollection;
private IServiceScope _serviceScope;
private IUserExceptionInformer _userExceptionInformer; private IUserExceptionInformer _userExceptionInformer;
public AbpExceptionHandlingLogger(IServiceCollection serviceCollection) public AbpExceptionHandlingLogger(IServiceCollection serviceCollection)
@ -50,8 +49,7 @@ namespace Volo.Abp.AspNetCore.Components.WebAssembly.ExceptionHandling
return; return;
} }
_serviceScope = serviceProvider.CreateScope(); _userExceptionInformer = serviceProvider.GetRequiredService<IUserExceptionInformer>();
_userExceptionInformer = _serviceScope.ServiceProvider.GetRequiredService<IUserExceptionInformer>();
} }
public virtual bool IsEnabled(LogLevel logLevel) public virtual bool IsEnabled(LogLevel logLevel)
@ -63,10 +61,5 @@ namespace Volo.Abp.AspNetCore.Components.WebAssembly.ExceptionHandling
{ {
return NullDisposable.Instance; return NullDisposable.Instance;
} }
public virtual void Dispose()
{
_serviceScope?.Dispose();
}
} }
} }

2
framework/src/Volo.Abp.AspNetCore.Components.WebAssembly/Volo/Abp/AspNetCore/Components/WebAssembly/ExceptionHandling/AbpExceptionHandlingLoggerProvider.cs

@ -32,7 +32,7 @@ namespace Volo.Abp.AspNetCore.Components.WebAssembly.ExceptionHandling
public void Dispose() public void Dispose()
{ {
_logger.Dispose();
} }
} }
} }

Loading…
Cancel
Save