From 9c524467305f27bc227b42633229652449d109a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= Date: Wed, 7 Sep 2022 15:31:43 +0300 Subject: [PATCH] MVC JavaScript APIs should generate script in the UI side They should not get the configuration from backend (for a tiered / microservice scenario). For tiered, this has a better pefrormance. For microservice, UI will know more than the service that returns the configuration and localizations. --- .../AbpApplicationConfigurationScriptController.cs | 4 ++-- .../AbpApplicationLocalizationScriptController.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationScriptController.cs b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationScriptController.cs index 791f5ca262..7fafee261c 100644 --- a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationScriptController.cs +++ b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationScriptController.cs @@ -17,14 +17,14 @@ namespace Volo.Abp.AspNetCore.Mvc.ApplicationConfigurations; [ApiExplorerSettings(IgnoreApi = true)] public class AbpApplicationConfigurationScriptController : AbpController { - private readonly IAbpApplicationConfigurationAppService _configurationAppService; + private readonly AbpApplicationConfigurationAppService _configurationAppService; private readonly IJsonSerializer _jsonSerializer; private readonly AbpAspNetCoreMvcOptions _options; private readonly IJavascriptMinifier _javascriptMinifier; private readonly IAbpAntiForgeryManager _antiForgeryManager; public AbpApplicationConfigurationScriptController( - IAbpApplicationConfigurationAppService configurationAppService, + AbpApplicationConfigurationAppService configurationAppService, IJsonSerializer jsonSerializer, IOptions options, IJavascriptMinifier javascriptMinifier, diff --git a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpApplicationLocalizationScriptController.cs b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpApplicationLocalizationScriptController.cs index fe7df42bf3..d8da85f871 100644 --- a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpApplicationLocalizationScriptController.cs +++ b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpApplicationLocalizationScriptController.cs @@ -20,13 +20,13 @@ namespace Volo.Abp.AspNetCore.Mvc.Localization; [ApiExplorerSettings(IgnoreApi = true)] public class AbpApplicationLocalizationScriptController : AbpController { - protected IAbpApplicationLocalizationAppService LocalizationAppService { get; } + protected AbpApplicationLocalizationAppService LocalizationAppService { get; } protected AbpAspNetCoreMvcOptions Options { get; } protected IJsonSerializer JsonSerializer { get; } protected IJavascriptMinifier JavascriptMinifier { get; } public AbpApplicationLocalizationScriptController( - IAbpApplicationLocalizationAppService localizationAppService, + AbpApplicationLocalizationAppService localizationAppService, IOptions options, IJsonSerializer jsonSerializer, IJavascriptMinifier javascriptMinifier)