From 9eb6a63f31b48229ad77c3f416f11d9223b24ace Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= Date: Thu, 14 Jan 2021 10:45:02 +0300 Subject: [PATCH] Added EnableObsoleteDbContextCreationWarning to disable logs. --- .../Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs | 3 ++- .../Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs | 3 ++- framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWork.cs | 6 ++++-- .../src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWorkManager.cs | 7 ++++++- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs b/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs index 364a29fb07..564a3ef8ad 100644 --- a/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs +++ b/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs @@ -39,7 +39,8 @@ namespace Volo.Abp.Uow.EntityFrameworkCore [Obsolete("Use GetDbContextAsync method.")] public TDbContext GetDbContext() { - if (!UnitOfWork.DisableObsoleteDbContextCreationWarning.Value) + if (UnitOfWork.EnableObsoleteDbContextCreationWarning && + !UnitOfWorkManager.DisableObsoleteDbContextCreationWarning.Value) { Logger.LogWarning( "UnitOfWorkDbContextProvider.GetDbContext is deprecated. Use GetDbContextAsync instead! " + diff --git a/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs b/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs index 6db6aec6b5..2b279f9c37 100644 --- a/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs +++ b/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs @@ -36,7 +36,8 @@ namespace Volo.Abp.Uow.MongoDB [Obsolete("Use CreateDbContextAsync")] public TMongoDbContext GetDbContext() { - if (!UnitOfWork.DisableObsoleteDbContextCreationWarning.Value) + if (UnitOfWork.EnableObsoleteDbContextCreationWarning && + !UnitOfWorkManager.DisableObsoleteDbContextCreationWarning.Value) { Logger.LogWarning( "UnitOfWorkDbContextProvider.GetDbContext is deprecated. Use GetDbContextAsync instead! " + diff --git a/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWork.cs b/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWork.cs index 2e4b40877f..955fa6b449 100644 --- a/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWork.cs +++ b/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWork.cs @@ -11,8 +11,10 @@ namespace Volo.Abp.Uow { public class UnitOfWork : IUnitOfWork, ITransientDependency { - [Obsolete("This will be removed in next versions.")] - public static AsyncLocal DisableObsoleteDbContextCreationWarning { get; } = new AsyncLocal(); + /// + /// Default: false. + /// + public static bool EnableObsoleteDbContextCreationWarning { get; } = false; public const string UnitOfWorkReservationName = "_AbpActionUnitOfWork"; diff --git a/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWorkManager.cs b/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWorkManager.cs index 3a3ef1fbd6..de0d8daa0a 100644 --- a/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWorkManager.cs +++ b/framework/src/Volo.Abp.Uow/Volo/Abp/Uow/UnitOfWorkManager.cs @@ -1,10 +1,15 @@ -using Microsoft.Extensions.DependencyInjection; +using System; +using System.Threading; +using Microsoft.Extensions.DependencyInjection; using Volo.Abp.DependencyInjection; namespace Volo.Abp.Uow { public class UnitOfWorkManager : IUnitOfWorkManager, ISingletonDependency { + [Obsolete("This will be removed in next versions.")] + public static AsyncLocal DisableObsoleteDbContextCreationWarning { get; } = new AsyncLocal(); + public IUnitOfWork Current => GetCurrentUnitOfWork(); private readonly IServiceScopeFactory _serviceScopeFactory;