From a234ccc98f03f7f77b2cf3591029c29759160f92 Mon Sep 17 00:00:00 2001 From: Arman Ozak Date: Tue, 1 Dec 2020 19:34:44 +0300 Subject: [PATCH] fix: remove pristine check from validators --- .../packages/core/src/lib/validators/age.validator.ts | 2 -- .../packages/core/src/lib/validators/credit-card.validator.ts | 2 -- .../packages/core/src/lib/validators/range.validator.ts | 2 -- .../packages/core/src/lib/validators/required.validator.ts | 4 +--- .../core/src/lib/validators/string-length.validator.ts | 2 -- .../packages/core/src/lib/validators/url.validator.ts | 2 -- 6 files changed, 1 insertion(+), 13 deletions(-) diff --git a/npm/ng-packs/packages/core/src/lib/validators/age.validator.ts b/npm/ng-packs/packages/core/src/lib/validators/age.validator.ts index a57c2ba38b..ee2e7f9fd3 100644 --- a/npm/ng-packs/packages/core/src/lib/validators/age.validator.ts +++ b/npm/ng-packs/packages/core/src/lib/validators/age.validator.ts @@ -12,8 +12,6 @@ export interface MinAgeOptions { export function validateMinAge({ age = 18 }: MinAgeOptions = {}): ValidatorFn { return (control: AbstractControl): MinAgeError | null => { - if (control.pristine) return null; - if (['', null, undefined].indexOf(control.value) > -1) return null; return isValidMinAge(control.value, age) ? null : { minAge: { age } }; diff --git a/npm/ng-packs/packages/core/src/lib/validators/credit-card.validator.ts b/npm/ng-packs/packages/core/src/lib/validators/credit-card.validator.ts index 70de5eca77..b4ca128ef5 100644 --- a/npm/ng-packs/packages/core/src/lib/validators/credit-card.validator.ts +++ b/npm/ng-packs/packages/core/src/lib/validators/credit-card.validator.ts @@ -6,8 +6,6 @@ export interface CreditCardError { export function validateCreditCard(): ValidatorFn { return (control: AbstractControl): CreditCardError | null => { - if (control.pristine) return null; - if (['', null, undefined].indexOf(control.value) > -1) return null; return isValidCreditCard(String(control.value)) ? null : { creditCard: true }; diff --git a/npm/ng-packs/packages/core/src/lib/validators/range.validator.ts b/npm/ng-packs/packages/core/src/lib/validators/range.validator.ts index c9e6edee6a..9497ed0407 100644 --- a/npm/ng-packs/packages/core/src/lib/validators/range.validator.ts +++ b/npm/ng-packs/packages/core/src/lib/validators/range.validator.ts @@ -14,8 +14,6 @@ export interface RangeOptions { export function validateRange({ maximum = Infinity, minimum = 0 }: RangeOptions = {}): ValidatorFn { return (control: AbstractControl): RangeError | null => { - if (control.pristine) return null; - if (['', null, undefined].indexOf(control.value) > -1) return null; const value = Number(control.value); diff --git a/npm/ng-packs/packages/core/src/lib/validators/required.validator.ts b/npm/ng-packs/packages/core/src/lib/validators/required.validator.ts index f8d27a3ffd..bf2a4b47ee 100644 --- a/npm/ng-packs/packages/core/src/lib/validators/required.validator.ts +++ b/npm/ng-packs/packages/core/src/lib/validators/required.validator.ts @@ -10,9 +10,7 @@ export interface RequiredOptions { export function validateRequired({ allowEmptyStrings }: RequiredOptions = {}): ValidatorFn { return (control: AbstractControl): RequiredError | null => { - return control.pristine || isValidRequired(control.value, allowEmptyStrings) - ? null - : { required: true }; + return isValidRequired(control.value, allowEmptyStrings) ? null : { required: true }; }; } diff --git a/npm/ng-packs/packages/core/src/lib/validators/string-length.validator.ts b/npm/ng-packs/packages/core/src/lib/validators/string-length.validator.ts index 167240cfa6..934188a4fb 100644 --- a/npm/ng-packs/packages/core/src/lib/validators/string-length.validator.ts +++ b/npm/ng-packs/packages/core/src/lib/validators/string-length.validator.ts @@ -19,8 +19,6 @@ export function validateStringLength({ minimumLength = 0, }: StringLengthOptions = {}): ValidatorFn { return (control: AbstractControl): StringLengthError | null => { - if (control.pristine) return null; - if (['', null, undefined].indexOf(control.value) > -1) return null; const value = String(control.value); diff --git a/npm/ng-packs/packages/core/src/lib/validators/url.validator.ts b/npm/ng-packs/packages/core/src/lib/validators/url.validator.ts index 6eb3169837..705d07e17a 100644 --- a/npm/ng-packs/packages/core/src/lib/validators/url.validator.ts +++ b/npm/ng-packs/packages/core/src/lib/validators/url.validator.ts @@ -6,8 +6,6 @@ export interface UrlError { export function validateUrl(): ValidatorFn { return (control: AbstractControl): UrlError | null => { - if (control.pristine) return null; - if (['', null, undefined].indexOf(control.value) > -1) return null; return isValidUrl(control.value) ? null : { url: true };