Browse Source

Improvements on api versioning.

pull/122/head
Halil İbrahim Kalkan 9 years ago
parent
commit
a3bd9c8c72
  1. 6
      src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/DynamicHttpProxyInterceptor.cs
  2. 2
      src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/UrlBuilder.cs
  3. 3
      test/Volo.Abp.AspNetCore.Mvc.Versioning.Tests/Volo/Abp/AspNetCore/Mvc/Versioning/AbpAspNetCoreMvcVersioningTestModule.cs

6
src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/DynamicHttpProxyInterceptor.cs

@ -130,7 +130,11 @@ namespace Volo.Abp.Http.Client.DynamicProxying
private ApiVersionInfo GetApiVersionInfo(ActionApiDescriptionModel action)
{
var apiVersion = FindBestApiVersion(action);
var versionParam = action.Parameters.FirstOrDefault(p => p.Name == "apiVersion");
//TODO: Make names configurable!
var versionParam = action.Parameters.FirstOrDefault(p => p.Name == "apiVersion") ??
action.Parameters.FirstOrDefault(p => p.Name == "api-version" && p.BindingSourceId == ParameterBindingSources.Query);
return new ApiVersionInfo(versionParam?.BindingSourceId, apiVersion);
}

2
src/Volo.Abp.Http.Client/Volo/Abp/Http/Client/DynamicProxying/UrlBuilder.cs

@ -84,7 +84,7 @@ namespace Volo.Abp.Http.Client.DynamicProxying
if (apiVersion.ShouldSendInQueryString())
{
AddQueryStringParameter(urlBuilder, isFirstParam, "apiVersion", apiVersion.Version); //TODO: Constant!
AddQueryStringParameter(urlBuilder, isFirstParam, "api-version", apiVersion.Version); //TODO: Constant!
}
}

3
test/Volo.Abp.AspNetCore.Mvc.Versioning.Tests/Volo/Abp/AspNetCore/Mvc/Versioning/AbpAspNetCoreMvcVersioningTestModule.cs

@ -46,7 +46,8 @@ namespace Volo.Abp.AspNetCore.Mvc.Versioning
options.ReportApiVersions = true;
options.AssumeDefaultVersionWhenUnspecified = true;
options.ApiVersionReader = new QueryStringApiVersionReader("apiVersion");
//options.ApiVersionReader = new UrlSegmentApiVersionReader();
//options.ApiVersionReader = new MediaTypeApiVersionReader();
options.ConfigureAbp(services);
});

Loading…
Cancel
Save