CmsKit: last changes after review

modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/Ratings/RatingConsts.cs

@@ -8,8 +8,8 @@ namespace Volo.CmsKit.Ratings
 
         public static int MaxEntityIdLength { get; set; } = CmsEntityConsts.MaxEntityIdLength;
 
-        public static int MaxRating { get; set; } = 5;
+        public const int MaxStarCount = 5;
 
-        public static int MinRating { get; set; } = 0;
+        public const int MinStarCount = 1;
     }
 }

modules/cms-kit/src/Volo.CmsKit.Domain/Volo/CmsKit/Ratings/Rating.cs

@@ -44,13 +44,13 @@ namespace Volo.CmsKit.Ratings
 
         public virtual void SetStarCount(short starCount)
         {
-            if(starCount <= RatingConsts.MaxRating && starCount > RatingConsts.MinRating)
+            if(starCount <= RatingConsts.MaxStarCount && starCount >= RatingConsts.MinStarCount)
             {
                 StarCount = starCount;
             }
             else
             {
-                throw new ArgumentOutOfRangeException("Choosen star must between 1 and 5");
+                throw new ArgumentOutOfRangeException($"Choosen star must between {RatingConsts.MinStarCount} and {RatingConsts.MaxStarCount}");
             }
         }
     }

modules/cms-kit/src/Volo.CmsKit.Public.Application.Contracts/Volo/CmsKit/Public/Ratings/CreateUpdateRatingInput.cs

@@ -1,10 +1,11 @@
 using System.ComponentModel.DataAnnotations;
+using Volo.CmsKit.Ratings;
 
 namespace Volo.CmsKit.Public.Ratings
 {
     public class CreateUpdateRatingInput
     {
-        [Required, Range(1, 5)]
+        [Required, Range(RatingConsts.MinStarCount, RatingConsts.MaxStarCount)]
         public short StarCount { get; set; }
     }
 }

modules/cms-kit/src/Volo.CmsKit.Public.Web/Pages/CmsKit/Shared/Components/Rating/Default.cshtml

@@ -5,7 +5,7 @@
 @model Volo.CmsKit.Public.Web.Pages.CmsKit.Shared.Components.Rating.RatingViewModel
 @inject IHtmlLocalizer<CmsKitResource> L
 
-<div class="cms-rating-area container" data-entity-type="@Model.EntityType" data-entity-id="@Model.EntityId">
+<div class="cms-rating-area container" data-entity-type="@Model.EntityType" data-entity-id="@Model.EntityId" id="cms-rating_{@Model.EntityType}_{@Model.EntityId}">
     @if (CurrentUser.IsAuthenticated)
     {
         <div class="m-auto">

modules/cms-kit/src/Volo.CmsKit.Public.Web/Pages/CmsKit/Shared/Components/Rating/RatingViewComponent.cs

@@ -42,7 +42,7 @@ namespace Volo.CmsKit.Public.Web.Pages.CmsKit.Shared.Components.Rating
             }
             
             var loginUrl =
-                $"{AbpMvcUiOptions.LoginUrl}?returnUrl={HttpContext.Request.Path.ToString()}&returnUrlHash=#cms-comment_{entityType}_{entityId}";
+                $"{AbpMvcUiOptions.LoginUrl}?returnUrl={HttpContext.Request.Path.ToString()}&returnUrlHash=#cms-rating_{entityType}_{entityId}";
 
             var viewModel = new RatingViewModel
             {

modules/cms-kit/src/Volo.CmsKit.Public.Web/Pages/CmsKit/Shared/Components/Rating/default.js

@@ -72,8 +72,7 @@
                 init: init,
                 getFilters: getFilters
             }
-        }
-        ;
+        };
 
         $('.abp-widget-wrapper[data-widget-name="CmsRating"]')
             .each(function () {
@@ -83,7 +82,6 @@
 
                 widgetManager.init($(this));
             });
-    })
-    ;
+    });
 })
 (jQuery);