Browse Source
Skip the permission update when the modal posts no change
- Assert that no per-permission state check runs in the batched read test
pull/26127/head
maliming
3 days ago
No known key found for this signature in database
GPG Key ID: A646B9CB645ECEA4
2 changed files with
6 additions and
0 deletions
-
modules/permission-management/src/Volo.Abp.PermissionManagement.Web/Pages/AbpPermissionManagement/PermissionManagementModal.cshtml.cs
-
modules/permission-management/test/Volo.Abp.PermissionManagement.Domain.Tests/Volo/Abp/PermissionManagement/PermissionManager_Tests.cs
|
|
@ -110,6 +110,11 @@ public class PermissionManagementModal : AbpPageModel |
|
|
}) |
|
|
}) |
|
|
.ToArray(); |
|
|
.ToArray(); |
|
|
|
|
|
|
|
|
|
|
|
if (updatePermissionDtos.IsNullOrEmpty()) |
|
|
|
|
|
{ |
|
|
|
|
|
return NoContent(); |
|
|
|
|
|
} |
|
|
|
|
|
|
|
|
await PermissionAppService.UpdateAsync( |
|
|
await PermissionAppService.UpdateAsync( |
|
|
ProviderName, |
|
|
ProviderName, |
|
|
ProviderKey, |
|
|
ProviderKey, |
|
|
|
|
|
@ -98,6 +98,7 @@ public class PermissionManager_Tests : PermissionTestBase |
|
|
_stateCheckerCounter.Reset(); |
|
|
_stateCheckerCounter.Reset(); |
|
|
var grantedProviders = await _permissionManager.GetAsync(names, "Test", "Test"); |
|
|
var grantedProviders = await _permissionManager.GetAsync(names, "Test", "Test"); |
|
|
_stateCheckerCounter.BatchCheckCount.ShouldBe(1); |
|
|
_stateCheckerCounter.BatchCheckCount.ShouldBe(1); |
|
|
|
|
|
_stateCheckerCounter.SingleCheckCount.ShouldBe(0); |
|
|
|
|
|
|
|
|
grantedProviders.Result.Single(x => x.Name == "MyPermission1").IsGranted.ShouldBeTrue(); |
|
|
grantedProviders.Result.Single(x => x.Name == "MyPermission1").IsGranted.ShouldBeTrue(); |
|
|
grantedProviders.Result.Single(x => x.Name == "MyPermission5").IsGranted.ShouldBeFalse(); |
|
|
grantedProviders.Result.Single(x => x.Name == "MyPermission5").IsGranted.ShouldBeFalse(); |
|
|
|