From ba46efa9cf36b5f31b0190579880380c5e7296f1 Mon Sep 17 00:00:00 2001 From: Yunus Emre Kalkan Date: Thu, 26 May 2022 12:14:19 +0300 Subject: [PATCH 1/2] Cli: Check file exist in NugetPackageToLocalReferenceConverter --- .../NugetPackageToLocalReferenceConverter.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs index 3082f59807..3be2428a79 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs @@ -30,6 +30,11 @@ public class NugetPackageToLocalReferenceConverter : ITransientDependency foreach (var projectFile in projectFiles) { + if (!File.Exists(projectFile)) + { + return; + } + var content = File.ReadAllText(projectFile); using (var stream = StreamHelper.GenerateStreamFromString(content)) { From bd63b965a5914c4d97138e93311560997444aab7 Mon Sep 17 00:00:00 2001 From: Yunus Emre Kalkan Date: Thu, 26 May 2022 13:42:17 +0300 Subject: [PATCH 2/2] Added logs --- .../NugetPackageToLocalReferenceConverter.cs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs index 3be2428a79..bb9360b550 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NugetPackageToLocalReferenceConverter.cs @@ -5,6 +5,8 @@ using System.Linq; using System.Text; using System.Threading.Tasks; using System.Xml; +using Microsoft.Extensions.Logging; +using Microsoft.Extensions.Logging.Abstractions; using Volo.Abp.Cli.Utils; using Volo.Abp.DependencyInjection; @@ -12,6 +14,12 @@ namespace Volo.Abp.Cli.ProjectModification; public class NugetPackageToLocalReferenceConverter : ITransientDependency { + public ILogger Logger { get; set; } + + public NugetPackageToLocalReferenceConverter(){ + Logger = NullLogger.Instance; + } + public async Task Convert(ModuleWithMastersInfo module, string solutionFile, string modulePrefix = "Volo.") { var nugetPackageList = GetNugetPackages(module); @@ -32,6 +40,7 @@ public class NugetPackageToLocalReferenceConverter : ITransientDependency { if (!File.Exists(projectFile)) { + Logger.LogWarning($"{projectFile} could not be found, skipping..."); return; }