From ad49f51c351ba9963d434c4d9ac15791636f4714 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= <hi_kalkan@yahoo.com>
Date: Fri, 25 Dec 2020 20:53:22 +0300
Subject: [PATCH] Better warning message

---
 .../UnitOfWorkDbContextProvider.cs                  |  8 ++++++--
 .../Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs | 13 +++++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs b/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs
index 7490862b95..143a5659cc 100644
--- a/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs
+++ b/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Uow/EntityFrameworkCore/UnitOfWorkDbContextProvider.cs
@@ -39,8 +39,12 @@ namespace Volo.Abp.Uow.EntityFrameworkCore
         [Obsolete("Use GetDbContextAsync method.")]
         public TDbContext GetDbContext()
         {
-            Logger.LogWarning("UnitOfWorkDbContextProvider.GetDbContext is deprecated. Use GetDbContextAsync instead!");
-            Logger.LogWarning(Environment.StackTrace);
+            Logger.LogWarning(
+                "UnitOfWorkDbContextProvider.GetDbContext is deprecated. Use GetDbContextAsync instead! " +
+                "You are probably using LINQ (LINQ extensions) directly on a repository. In this case, use repository.GetQueryableAsync() method " +
+                "to obtain an IQueryable<T> instance and use LINQ (LINQ extensions) on this object. "
+            );
+            Logger.LogWarning(Environment.StackTrace.Truncate(2048));
 
             var unitOfWork = _unitOfWorkManager.Current;
             if (unitOfWork == null)
diff --git a/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs b/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs
index a3d6fe7cf4..724e7673fc 100644
--- a/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs
+++ b/framework/src/Volo.Abp.MongoDB/Volo/Abp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs
@@ -2,6 +2,8 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Abstractions;
 using MongoDB.Bson;
 using MongoDB.Driver;
 using Volo.Abp.Data;
@@ -13,6 +15,8 @@ namespace Volo.Abp.Uow.MongoDB
     public class UnitOfWorkMongoDbContextProvider<TMongoDbContext> : IMongoDbContextProvider<TMongoDbContext>
         where TMongoDbContext : IAbpMongoDbContext
     {
+        public ILogger<UnitOfWorkMongoDbContextProvider<TMongoDbContext>> Logger { get; set; }
+
         private readonly IUnitOfWorkManager _unitOfWorkManager;
         private readonly IConnectionStringResolver _connectionStringResolver;
         private readonly ICancellationTokenProvider _cancellationTokenProvider;
@@ -25,11 +29,20 @@ namespace Volo.Abp.Uow.MongoDB
             _unitOfWorkManager = unitOfWorkManager;
             _connectionStringResolver = connectionStringResolver;
             _cancellationTokenProvider = cancellationTokenProvider;
+
+            Logger = NullLogger<UnitOfWorkMongoDbContextProvider<TMongoDbContext>>.Instance;
         }
 
         [Obsolete("Use CreateDbContextAsync")]
         public TMongoDbContext GetDbContext()
         {
+            Logger.LogWarning(
+                "UnitOfWorkDbContextProvider.GetDbContext is deprecated. Use GetDbContextAsync instead! " +
+                "You are probably using LINQ (LINQ extensions) directly on a repository. In this case, use repository.GetQueryableAsync() method " +
+                "to obtain an IQueryable<T> instance and use LINQ (LINQ extensions) on this object. "
+            );
+            Logger.LogWarning(Environment.StackTrace.Truncate(2048));
+
             var unitOfWork = _unitOfWorkManager.Current;
             if (unitOfWork == null)
             {