From b1bc394d21399559f0358fc48689ff2899eaa208 Mon Sep 17 00:00:00 2001 From: maliming Date: Fri, 20 Jun 2025 15:55:01 +0800 Subject: [PATCH] fix: ensure provider policy check before deleting feature --- .../Volo/Abp/FeatureManagement/FeatureAppService.cs | 1 + .../FeatureManagementApplicationTestModule.cs | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs b/modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs index 5f4f55a3fe..4423036b51 100644 --- a/modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs +++ b/modules/feature-management/src/Volo.Abp.FeatureManagement.Application/Volo/Abp/FeatureManagement/FeatureAppService.cs @@ -137,6 +137,7 @@ public class FeatureAppService : FeatureManagementAppServiceBase, IFeatureAppSer public virtual async Task DeleteAsync([NotNull] string providerName, string providerKey) { + await CheckProviderPolicy(providerName, providerKey); await FeatureManager.DeleteAsync(providerName, providerKey); } } diff --git a/modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureManagementApplicationTestModule.cs b/modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureManagementApplicationTestModule.cs index c085b68846..7e962463e6 100644 --- a/modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureManagementApplicationTestModule.cs +++ b/modules/feature-management/test/Volo.Abp.FeatureManagement.Application.Tests/Volo/Abp/FeatureManagement/FeatureManagementApplicationTestModule.cs @@ -8,5 +8,11 @@ namespace Volo.Abp.FeatureManagement; )] public class FeatureManagementApplicationTestModule : AbpModule { - + public override void ConfigureServices(ServiceConfigurationContext context) + { + Configure(options => + { + options.ProviderPolicies["test"] = FeatureManagementPermissions.ManageHostFeatures; + }); + } }