Browse Source

Merge pull request #21724 from abpframework/MailAddressCollection

Use `MailAddressCollection` class to validate the email address.
pull/21729/head
Engincan VESKE 2 years ago
committed by GitHub
parent
commit
b4defa1e05
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 17
      framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/EmailSenderBase.cs

17
framework/src/Volo.Abp.Emailing/Volo/Abp/Emailing/EmailSenderBase.cs

@ -92,7 +92,7 @@ public abstract class EmailSenderBase : IEmailSender
public virtual async Task QueueAsync(string to, string subject, string body, bool isBodyHtml = true, AdditionalEmailSendingArgs? additionalEmailSendingArgs = null)
{
ValidateEmailAddress(to);
await ValidateEmailAddressAsync(to);
if (!BackgroundJobManager.IsAvailable())
{
@ -115,7 +115,7 @@ public abstract class EmailSenderBase : IEmailSender
public virtual async Task QueueAsync(string from, string to, string subject, string body, bool isBodyHtml = true, AdditionalEmailSendingArgs? additionalEmailSendingArgs = null)
{
ValidateEmailAddress(to);
await ValidateEmailAddressAsync(to);
if (!BackgroundJobManager.IsAvailable())
{
@ -176,13 +176,16 @@ public abstract class EmailSenderBase : IEmailSender
}
}
private static void ValidateEmailAddress(string emailAddress)
protected virtual Task ValidateEmailAddressAsync(string emailAddress)
{
if(ValidationHelper.IsValidEmailAddress(emailAddress))
try
{
return;
_ = new MailAddressCollection { emailAddress };
return Task.CompletedTask;
}
catch (Exception e)
{
throw new ArgumentException($"Email address '{emailAddress}' is not valid!");
}
throw new ArgumentException($"Email address '{emailAddress}' is not valid!");
}
}

Loading…
Cancel
Save