From 5f199cb778655abc6d83a4c5498951022281994d Mon Sep 17 00:00:00 2001 From: John Karam <168653085+johnkaram02@users.noreply.github.com> Date: Tue, 27 Oct 2026 23:18:45 +0000 Subject: [PATCH 1/2] Handle undefined and combined flag values in AbpEnumLocalizer AbpEnumLocalizer used Type.GetEnumName as the member name. GetEnumName returns null for a value that has no named member, such as (BookType)42 or a combination of [Flags] members. The null key then reached the string localizer and GetString threw an ArgumentNullException. Fall back to the enum's ToString() result, such as "42" or "Read, Write", when the value has no named member. --- .../Volo/Abp/Localization/AbpEnumLocalizer.cs | 2 +- .../Localization/AbpEnumLocalizer_Tests.cs | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/framework/src/Volo.Abp.Localization/Volo/Abp/Localization/AbpEnumLocalizer.cs b/framework/src/Volo.Abp.Localization/Volo/Abp/Localization/AbpEnumLocalizer.cs index b2acb3d072..395c21e58d 100644 --- a/framework/src/Volo.Abp.Localization/Volo/Abp/Localization/AbpEnumLocalizer.cs +++ b/framework/src/Volo.Abp.Localization/Volo/Abp/Localization/AbpEnumLocalizer.cs @@ -26,7 +26,7 @@ public class AbpEnumLocalizer : IAbpEnumLocalizer, ITransientDependency protected virtual string GetStringInternal(Type enumType, object enumValue, params IStringLocalizer?[] specifyLocalizers) { - var memberName = enumType.GetEnumName(enumValue)!; + var memberName = enumType.GetEnumName(enumValue) ?? Enum.ToObject(enumType, enumValue).ToString()!; var localizedString = GetStringOrNull( specifyLocalizers, new[] diff --git a/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs b/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs index c53236809f..573f089f00 100644 --- a/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs +++ b/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs @@ -37,6 +37,17 @@ public class AbpEnumLocalizer_Tests : AbpIntegratedTest(BookType.Biography, specifyLocalizer).ShouldBe("Biography from ValidationResource"); } } + + [Fact] + public void GetString_With_Undefined_Value_Test() + { + using (CultureHelper.Use("en")) + { + _enumLocalizer.GetString(42).ShouldBe("42"); + _enumLocalizer.GetString((BookType)42).ShouldBe("42"); + _enumLocalizer.GetString(BookPermissions.Read | BookPermissions.Write).ShouldBe("Read, Write"); + } + } } enum BookType @@ -45,3 +56,11 @@ enum BookType Adventure, Biography, } + +[System.Flags] +enum BookPermissions +{ + None = 0, + Read = 1, + Write = 2, +} From ce06e78ae5df502d2cdc65b517a9aed487678c3d Mon Sep 17 00:00:00 2001 From: maliming Date: Wed, 28 Oct 2026 13:29:10 +0800 Subject: [PATCH 2/2] Cover more undefined enum values and apply the fallback to EnumHelper --- .../Components/ObjectExtending/EnumHelper.cs | 2 +- .../Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/framework/src/Volo.Abp.BlazoriseUI/Components/ObjectExtending/EnumHelper.cs b/framework/src/Volo.Abp.BlazoriseUI/Components/ObjectExtending/EnumHelper.cs index a3d26fd317..a42d0b0362 100644 --- a/framework/src/Volo.Abp.BlazoriseUI/Components/ObjectExtending/EnumHelper.cs +++ b/framework/src/Volo.Abp.BlazoriseUI/Components/ObjectExtending/EnumHelper.cs @@ -9,7 +9,7 @@ public static class EnumHelper [Obsolete("Use IAbpEnumLocalizer instead.")] public static string GetLocalizedMemberName(Type enumType, object value, IStringLocalizerFactory stringLocalizerFactory) { - var memberName = enumType.GetEnumName(value); + var memberName = enumType.GetEnumName(value) ?? Enum.ToObject(enumType, value).ToString(); var localizedMemberName = AbpInternalLocalizationHelper.LocalizeWithFallback( new[] { diff --git a/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs b/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs index 573f089f00..b13f088fea 100644 --- a/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs +++ b/framework/test/Volo.Abp.Localization.Tests/Volo/Abp/Localization/AbpEnumLocalizer_Tests.cs @@ -46,6 +46,13 @@ public class AbpEnumLocalizer_Tests : AbpIntegratedTest(42).ShouldBe("42"); _enumLocalizer.GetString((BookType)42).ShouldBe("42"); _enumLocalizer.GetString(BookPermissions.Read | BookPermissions.Write).ShouldBe("Read, Write"); + _enumLocalizer.GetString(3).ShouldBe("Read, Write"); + + var specifyLocalizer = new[] + { + GetRequiredService().Create() + }; + _enumLocalizer.GetString(42, specifyLocalizer).ShouldBe("42"); } } }