Browse Source

Address review feedback on enum adapter comment and child UoW test

Co-authored-by: maliming <6908465+maliming@users.noreply.github.com>
pull/26129/head
copilot-swe-agent[bot] 3 days ago
committed by GitHub
parent
commit
b875866949
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 2
      framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/DataAnnotations/AbpValidationAttributeAdapterProvider_Tests.cs
  2. 2
      framework/test/Volo.Abp.Uow.Tests/Volo/Abp/Uow/UnitOfWork_Child_Events_Tests.cs

2
framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/DataAnnotations/AbpValidationAttributeAdapterProvider_Tests.cs

@ -17,7 +17,7 @@ public class AbpValidationAttributeAdapterProvider_Tests
[Fact]
public void Should_Return_An_Adapter_For_The_EnumDataTypeAttribute()
{
//The default ASP.NET Core provider returns null for it, that's why we supply our own adapter.
//ABP supplies its own adapter for the EnumDataTypeAttribute.
_provider.GetAttributeAdapter(new EnumDataTypeAttribute(typeof(MyEnum)), null)
.ShouldBeOfType<EnumDataTypeAttributeAdapter>();
}

2
framework/test/Volo.Abp.Uow.Tests/Volo/Abp/Uow/UnitOfWork_Child_Events_Tests.cs

@ -67,6 +67,8 @@ public class UnitOfWork_Child_Events_Tests : AbpIntegratedTest<AbpUnitOfWorkModu
using (var childUow = _unitOfWorkManager.Begin())
{
childUow.Id.ShouldBe(parentUow.Id); //It's a child of the parent UOW.
childUow.Disposed += OnDisposed;
childUow.Disposed -= OnDisposed;
}

Loading…
Cancel
Save