From ba9ab6fe2982475c3f29b06023c1ff80e5ea8d6d Mon Sep 17 00:00:00 2001
From: mehmet-erim <bilgi@mehmeterim.com>
Date: Mon, 11 Nov 2019 17:29:30 +0300
Subject: [PATCH] refactor(core): remove markAsDirty loop

---
 .../lib/directives/form-submit.directive.ts   | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/npm/ng-packs/packages/core/src/lib/directives/form-submit.directive.ts b/npm/ng-packs/packages/core/src/lib/directives/form-submit.directive.ts
index 00982bbbb9..5d0c6ef7a1 100644
--- a/npm/ng-packs/packages/core/src/lib/directives/form-submit.directive.ts
+++ b/npm/ng-packs/packages/core/src/lib/directives/form-submit.directive.ts
@@ -7,7 +7,7 @@ import {
   OnDestroy,
   OnInit,
   Output,
-  Self
+  Self,
 } from '@angular/core';
 import { FormControl, FormGroup, FormGroupDirective } from '@angular/forms';
 import { fromEvent } from 'rxjs';
@@ -18,7 +18,7 @@ type Controls = { [key: string]: FormControl } | FormGroup[];
 
 @Directive({
   // tslint:disable-next-line: directive-selector
-  selector: 'form[ngSubmit][formGroup]'
+  selector: 'form[ngSubmit][formGroup]',
 })
 export class FormSubmitDirective implements OnInit, OnDestroy {
   @Input()
@@ -31,7 +31,7 @@ export class FormSubmitDirective implements OnInit, OnDestroy {
   constructor(
     @Self() private formGroupDirective: FormGroupDirective,
     private host: ElementRef<HTMLFormElement>,
-    private cdRef: ChangeDetectorRef
+    private cdRef: ChangeDetectorRef,
   ) {}
 
   ngOnInit() {
@@ -44,7 +44,7 @@ export class FormSubmitDirective implements OnInit, OnDestroy {
       .pipe(
         debounceTime(200),
         filter((key: KeyboardEvent) => key && key.key === 'Enter'),
-        takeUntilDestroy(this)
+        takeUntilDestroy(this),
       )
       .subscribe(() => {
         if (!this.executedNgSubmit) {
@@ -53,17 +53,6 @@ export class FormSubmitDirective implements OnInit, OnDestroy {
 
         this.executedNgSubmit = false;
       });
-
-    fromEvent(this.host.nativeElement, 'submit')
-      .pipe(
-        takeUntilDestroy(this),
-        filter(() => !this.notValidateOnSubmit && typeof this.notValidateOnSubmit !== 'string')
-      )
-      .subscribe(() => {
-        if (!this.executedNgSubmit) {
-          this.markAsDirty();
-        }
-      });
   }
 
   ngOnDestroy(): void {}