From c0a8fdac1922b8fdae56cd05e5911e49cfd76fdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= Date: Tue, 30 Aug 2022 12:27:20 +0300 Subject: [PATCH] Use GetAllStringsAsync in AbpApplicationConfigurationAppService Also removed body of AbpLocalizationScriptController.GetAsync since it was not implemented yet. --- .../AbpApplicationConfigurationAppService.cs | 2 +- .../Localization/AbpLocalizationScriptController.cs | 13 +++---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationAppService.cs b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationAppService.cs index e2557aac0c..6d58172a16 100644 --- a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationAppService.cs +++ b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ApplicationConfigurations/AbpApplicationConfigurationAppService.cs @@ -232,7 +232,7 @@ public class AbpApplicationConfigurationAppService : ApplicationService, IAbpApp var localizer = StringLocalizerFactory.CreateByResourceNameOrNull(resourceName); if (localizer != null) { - foreach (var localizedString in localizer.GetAllStrings()) + foreach (var localizedString in await localizer.GetAllStringsAsync()) { dictionary[localizedString.Name] = localizedString.Value; } diff --git a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpLocalizationScriptController.cs b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpLocalizationScriptController.cs index f4e22e0f41..7b1b26ec71 100644 --- a/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpLocalizationScriptController.cs +++ b/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/Localization/AbpLocalizationScriptController.cs @@ -1,4 +1,5 @@ -using System.Threading.Tasks; +using System; +using System.Threading.Tasks; using Microsoft.AspNetCore.Mvc; using Microsoft.Extensions.Localization; using Microsoft.Extensions.Options; @@ -29,14 +30,6 @@ public class AbpLocalizationScriptController [Route("{culture}")] public async Task GetAsync(string culture) { - // TODO: Should not get dynamic overloads, but how? What if we do? (Can be switched to host?) - using (CultureHelper.Use(culture)) - { - foreach (var resource in LocalizationOptions.Resources.Values) - { - var localizer = StringLocalizerFactory.CreateByResourceNameOrNull(resource.ResourceName); - localizer?.GetAllStrings(); - } - } + throw new NotImplementedException(); } } \ No newline at end of file