From c5508d2f25613cb34d7df027a1a98ce7c41625aa Mon Sep 17 00:00:00 2001
From: TheDiaval <thediavall@gmail.com>
Date: Thu, 8 Aug 2019 17:27:16 +0300
Subject: [PATCH] fix(identity): hide password field of modal when editing an
 existing user

---
 .../lib/components/users/users.component.html   |  6 +++---
 .../src/lib/components/users/users.component.ts | 17 +++++++++--------
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html
index 03f5dcb605..df4b6a2eb5 100644
--- a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html
+++ b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html
@@ -88,7 +88,7 @@
         <ngb-tabset>
           <ngb-tab [title]="'AbpIdentity::UserInformations' | abpLocalization">
             <ng-template ngbTabContent>
-              <div class="mt-2">
+              <div class="mt-2 fade-in-top">
                 <div class="form-group">
                   <label for="user-name">{{ 'AbpIdentity::UserName' | abpLocalization }}</label
                   ><span> * </span>
@@ -105,7 +105,7 @@
                   <input type="text" id="surname" class="form-control" formControlName="surname" />
                 </div>
 
-                <div class="form-group">
+                <div *ngIf="!selected.userName" class="form-group">
                   <label for="password">{{ 'AbpIdentity::Password' | abpLocalization }}</label
                   ><span> * </span>
                   <input
@@ -156,7 +156,7 @@
           </ngb-tab>
           <ngb-tab [title]="'AbpIdentity::Roles' | abpLocalization">
             <ng-template ngbTabContent>
-              <div class="mt-2">
+              <div class="mt-2 fade-in-top">
                 <div
                   *ngFor="let roleGroup of roleGroups; let i = index; trackBy: trackByFn"
                   class="custom-checkbox custom-control mb-2"
diff --git a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts
index 337bf94abe..ed63c8acb5 100644
--- a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts
+++ b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts
@@ -1,10 +1,10 @@
 import { ABP } from '@abp/ng.core';
 import { ConfirmationService, Toaster } from '@abp/ng.theme.shared';
 import { Component, TemplateRef, TrackByFunction, ViewChild } from '@angular/core';
-import { AbstractControl, FormArray, FormBuilder, FormGroup, Validators } from '@angular/forms';
+import { AbstractControl, FormArray, FormBuilder, FormGroup, Validators, FormControl } from '@angular/forms';
 import { Select, Store } from '@ngxs/store';
-import { combineLatest, Observable } from 'rxjs';
-import { filter, finalize, map, pluck, take } from 'rxjs/operators';
+import { Observable } from 'rxjs';
+import { finalize, pluck, switchMap, take } from 'rxjs/operators';
 import snq from 'snq';
 import {
   IdentityAddUser,
@@ -65,9 +65,7 @@ export class UsersComponent {
 
   buildForm() {
     this.roles = this.store.selectSnapshot(IdentityState.getRoles);
-
     this.form = this.fb.group({
-      password: ['', [Validators.required, Validators.maxLength(32)]],
       userName: [this.selected.userName || '', [Validators.required, Validators.maxLength(256)]],
       email: [this.selected.email || '', [Validators.required, Validators.email, Validators.maxLength(256)]],
       name: [this.selected.name || '', [Validators.maxLength(64)]],
@@ -83,6 +81,9 @@ export class UsersComponent {
         ),
       ),
     });
+    if (!this.selected.userName) {
+      this.form.addControl('password', new FormControl('', [Validators.required, Validators.maxLength(32)]));
+    }
   }
 
   openModal() {
@@ -97,10 +98,10 @@ export class UsersComponent {
   }
 
   onEdit(id: string) {
-    combineLatest([this.store.dispatch(new IdentityGetUserById(id)), this.store.dispatch(new IdentityGetUserRoles(id))])
+    this.store
+      .dispatch(new IdentityGetUserById(id))
       .pipe(
-        filter(([res1, res2]) => res1 && res2),
-        map(([state, _]) => state),
+        switchMap(() => this.store.dispatch(new IdentityGetUserRoles(id))),
         pluck('IdentityState'),
         take(1),
       )