From c775f3e6d55410b2dc498cf8c259027eedd3462f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= <hi_kalkan@yahoo.com>
Date: Sat, 24 Dec 2016 15:29:51 +0300
Subject: [PATCH] Made Identity module initialized.

---
 .../Volo/Abp/Identity/EfCoreIdentityUserRepository.cs  | 10 +++++-----
 .../Volo/Abp/Identity/AbpIdentityModule.cs             |  2 ++
 .../Volo/Abp/Identity/AbpIdentityTestModule.cs         |  3 ++-
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EfCoreIdentityUserRepository.cs b/src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EfCoreIdentityUserRepository.cs
index 2a9975a197..22554181c1 100644
--- a/src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EfCoreIdentityUserRepository.cs
+++ b/src/Volo.Abp.Identity.EntityFrameworkCore/Volo/Abp/Identity/EfCoreIdentityUserRepository.cs
@@ -11,11 +11,11 @@ using Volo.Abp.Identity.EntityFrameworkCore;
 namespace Volo.Abp.Identity
 {
     //TODO: Register for;
-    //- IIdentityUserRepository
-    //- IRepository<IdentityUser>
-    //- IRepository<IdentityUser, string>
-    //- IQueryableRepository<IdentityUser>
-    //- IQueryableRepository<IdentityUser, string>
+    //- IIdentityUserRepository OK, by convention
+    //- IRepository<IdentityUser> -> none!
+    //- IRepository<IdentityUser, string> -> OK, by AddDefaultEfCoreRepositories but note to EfCoreIdentityUserRepository!
+    //- IQueryableRepository<IdentityUser> -> none!
+    //- IQueryableRepository<IdentityUser, string> - OK, by AddDefaultEfCoreRepositories, but not to EfCoreIdentityUserRepository!
     public class EfCoreIdentityUserRepository : EfCoreRepository<IdentityDbContext, IdentityUser>, IIdentityUserRepository
     {
         public EfCoreIdentityUserRepository(IDbContextProvider<IdentityDbContext> dbContextProvider) 
diff --git a/src/Volo.Abp.Identity/Volo/Abp/Identity/AbpIdentityModule.cs b/src/Volo.Abp.Identity/Volo/Abp/Identity/AbpIdentityModule.cs
index 60133f0855..f9b35ac40b 100644
--- a/src/Volo.Abp.Identity/Volo/Abp/Identity/AbpIdentityModule.cs
+++ b/src/Volo.Abp.Identity/Volo/Abp/Identity/AbpIdentityModule.cs
@@ -7,6 +7,8 @@ namespace Volo.Abp.Identity
     {
         public override void ConfigureServices(IServiceCollection services)
         {
+            //TODO: How to configure options of AddIdentity (and return value)
+            services.AddIdentity<IdentityUser, IdentityRole>();
             services.AddAssemblyOf<AbpIdentityModule>();
         }
     }
diff --git a/test/Volo.Abp.Identity.Tests/Volo/Abp/Identity/AbpIdentityTestModule.cs b/test/Volo.Abp.Identity.Tests/Volo/Abp/Identity/AbpIdentityTestModule.cs
index ecf749f279..e5db099dec 100644
--- a/test/Volo.Abp.Identity.Tests/Volo/Abp/Identity/AbpIdentityTestModule.cs
+++ b/test/Volo.Abp.Identity.Tests/Volo/Abp/Identity/AbpIdentityTestModule.cs
@@ -3,11 +3,12 @@ using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 using Volo.Abp.Data;
 using Volo.Abp.EntityFrameworkCore;
+using Volo.Abp.Identity.EntityFrameworkCore;
 using Volo.Abp.Modularity;
 
 namespace Volo.Abp.Identity
 {
-    [DependsOn(typeof(AbpIdentityModule))]
+    [DependsOn(typeof(AbpIdentityModule), typeof(AbpIdentityEntityFrameworkCoreModule))]
     public class AbpIdentityTestModule : AbpModule
     {
         public override void ConfigureServices(IServiceCollection services)