Browse Source

refactor(setting-management): remove unneccessary codes

pull/1756/head
mehmet-erim 7 years ago
parent
commit
c836349cca
  1. 2
      npm/ng-packs/packages/setting-management/src/lib/components/setting-layout.component.html
  2. 8
      npm/ng-packs/packages/setting-management/src/lib/components/setting-layout.component.ts
  3. 18
      npm/ng-packs/packages/setting-management/src/lib/services/setting-management.service.ts

2
npm/ng-packs/packages/setting-management/src/lib/components/setting-layout.component.html

@ -47,8 +47,6 @@
[id]="settingManagementService.selected.name + '-tab'" [id]="settingManagementService.selected.name + '-tab'"
role="tabpanel" role="tabpanel"
> >
<h2>{{ settingManagementService.selected.name | abpLocalization }}</h2>
<hr class="my-4" />
<router-outlet></router-outlet> <router-outlet></router-outlet>
</div> </div>
</div> </div>

8
npm/ng-packs/packages/setting-management/src/lib/components/setting-layout.component.ts

@ -26,12 +26,4 @@ export class SettingLayoutComponent {
} }
ngOnDestroy() {} ngOnDestroy() {}
ngAfterViewInit() {
timer(250).subscribe(() => {
if (!this.settingManagementService.settings.length) {
this.settingManagementService.setSettings();
}
});
}
} }

18
npm/ng-packs/packages/setting-management/src/lib/services/setting-management.service.ts

@ -15,21 +15,9 @@ export class SettingManagementService {
private destroy$ = new Subject(); private destroy$ = new Subject();
constructor(private router: Router, private store: Store) { constructor(private router: Router, private store: Store) {
let timeout: Subscription; setTimeout(() => {
this.router.events this.setSettings();
.pipe( }, 0);
filter(event => event instanceof RouteConfigLoadEnd),
takeUntil(this.destroy$),
)
.subscribe(event => {
if (timeout) {
timeout.unsubscribe();
this.destroy$.next();
}
timeout = timer(150).subscribe(() => {
this.setSettings();
});
});
} }
ngOnDestroy() { ngOnDestroy() {

Loading…
Cancel
Save