Browse Source

Merge pull request #13164 from abpframework/issues/10857-v2

Fix: Cli fails to copy angular files when adding new module
pull/13168/head
Yunus Emre Kalkan 4 years ago
committed by GitHub
parent
commit
d0a8383c80
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 13
      framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/AngularSourceCodeAdder.cs
  2. 29
      framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/SolutionModuleAdder.cs

13
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/AngularSourceCodeAdder.cs

@ -246,6 +246,17 @@ public class AngularSourceCodeAdder : ITransientDependency
foreach (var folder in angularPathsInDownloadedSourceCode)
{
var nodeModulesFolder = Path.Combine(folder, "node_modules");
var vscodeFolder = Path.Combine(folder, ".vscode");
if (Directory.Exists(nodeModulesFolder))
{
Directory.Delete(nodeModulesFolder, true);
}
if (Directory.Exists(vscodeFolder))
{
Directory.Delete(vscodeFolder, true);
}
var projectsInFolder = Directory.GetDirectories(folder);
if (projectsInFolder.Length == 1 && Path.GetFileName(projectsInFolder[0]) == "projects")
@ -286,7 +297,7 @@ public class AngularSourceCodeAdder : ITransientDependency
Directory.Move(projectInFolder, destDirName);
}
if (!Directory.GetFiles(folder).Any() && !Directory.GetDirectories(folder).Any())
if (!Directory.GetDirectories(folder).Any())
{
Directory.Delete(folder, true);
}

29
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/SolutionModuleAdder.cs

@ -427,11 +427,6 @@ public class SolutionModuleAdder : ITransientDependency
await PublishEventAsync(9, $"Adding angular source code");
if (newTemplate)
{
MoveAngularFolderInNewTemplate(modulesFolderInSolution, moduleName);
}
await AngularSourceCodeAdder.AddFromModuleAsync(solutionFilePath, angularPath);
}
@ -449,30 +444,6 @@ public class SolutionModuleAdder : ITransientDependency
}
}
private static void MoveAngularFolderInNewTemplate(string modulesFolderInSolution, string moduleName)
{
var moduleAngularFolder = Path.Combine(modulesFolderInSolution, moduleName, "angular");
if (!Directory.Exists(moduleAngularFolder))
{
return;
}
var files = Directory.GetFiles(moduleAngularFolder);
var folders = Directory.GetDirectories(moduleAngularFolder);
Directory.CreateDirectory(Path.Combine(moduleAngularFolder, moduleName));
foreach (var file in files)
{
File.Move(file, Path.Combine(moduleAngularFolder, moduleName, Path.GetFileName(file)));
}
foreach (var folder in folders)
{
Directory.Move(folder, Path.Combine(moduleAngularFolder, moduleName, Path.GetFileName(folder)));
}
}
private async Task DownloadSourceCodesToSolutionFolder(ModuleWithMastersInfo module,
string modulesFolderInSolution, string version = null, bool newTemplate = false,
bool newProTemplate = false)

Loading…
Cancel
Save