From d1b322756be4ffcb9776989fd98ea547cbb80086 Mon Sep 17 00:00:00 2001 From: Yunus Emre Kalkan Date: Wed, 11 Mar 2020 16:15:03 +0300 Subject: [PATCH] refactor --- .../Volo/Docs/Documents/DocumentUpdateInfo.cs | 2 -- .../Docs/GitHub/Documents/GithubDocumentSource.cs | 11 +++++++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/modules/docs/src/Volo.Docs.Domain.Shared/Volo/Docs/Documents/DocumentUpdateInfo.cs b/modules/docs/src/Volo.Docs.Domain.Shared/Volo/Docs/Documents/DocumentUpdateInfo.cs index fd330d9b45..9269c89b07 100644 --- a/modules/docs/src/Volo.Docs.Domain.Shared/Volo/Docs/Documents/DocumentUpdateInfo.cs +++ b/modules/docs/src/Volo.Docs.Domain.Shared/Volo/Docs/Documents/DocumentUpdateInfo.cs @@ -11,8 +11,6 @@ namespace Volo.Docs.Documents public virtual DateTime LastUpdatedTime { get; set; } - public virtual bool HasSignificantUpdates { get; set; } - public DateTime? LastSignificantUpdateTime { get; set; } } } \ No newline at end of file diff --git a/modules/docs/src/Volo.Docs.Domain/Volo/Docs/GitHub/Documents/GithubDocumentSource.cs b/modules/docs/src/Volo.Docs.Domain/Volo/Docs/GitHub/Documents/GithubDocumentSource.cs index ad96d48838..3e287789e9 100644 --- a/modules/docs/src/Volo.Docs.Domain/Volo/Docs/GitHub/Documents/GithubDocumentSource.cs +++ b/modules/docs/src/Volo.Docs.Domain/Volo/Docs/GitHub/Documents/GithubDocumentSource.cs @@ -104,9 +104,16 @@ namespace Volo.Docs.GitHub.Documents DateTime? lastKnownSignificantUpdateTime, DateTime documentCreationTime) { + if (!fileCommits.Any()) + { + return null; + } + + var fileCommitsAfterCreation = fileCommits.Take(fileCommits.Count - 1); + var commitsToEvaluate = (lastKnownSignificantUpdateTime != null - ? fileCommits.Where(c => c.Commit.Author.Date.DateTime > lastKnownSignificantUpdateTime) - : fileCommits).Where(c => c.Commit.Author.Date.DateTime > DateTime.Now.AddDays(-14) && c.Commit.Author.Date.DateTime > documentCreationTime); + ? fileCommitsAfterCreation.Where(c => c.Commit.Author.Date.DateTime > lastKnownSignificantUpdateTime) + : fileCommitsAfterCreation).Where(c => c.Commit.Author.Date.DateTime > DateTime.Now.AddDays(-14)); foreach (var gitHubCommit in commitsToEvaluate) {