Browse Source

Throw exception if provder was not found

pull/18823/head
liangshiwei 3 years ago
parent
commit
d3058a9a3e
  1. 2
      modules/feature-management/src/Volo.Abp.FeatureManagement.Domain/Volo/Abp/FeatureManagement/FeatureManager.cs
  2. 11
      modules/feature-management/test/Volo.Abp.FeatureManagement.Domain.Tests/Volo/Abp/FeatureManagement/FeatureManager_Tests.cs
  3. 15
      modules/permission-management/test/Volo.Abp.PermissionManagement.Domain.Tests/Volo/Abp/PermissionManagement/PermissionManager_Tests.cs
  4. 2
      modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/SettingManager.cs
  5. 7
      modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/SettingManager_Basic_Tests.cs

2
modules/feature-management/src/Volo.Abp.FeatureManagement.Domain/Volo/Abp/FeatureManagement/FeatureManager.cs

@ -144,7 +144,7 @@ public class FeatureManager : IFeatureManager, ISingletonDependency
if (!providers.Any())
{
return;
throw new AbpException($"Unknown feature value provider: {providerName}");
}
if (providers.Count > 1 && !forceToSet && value != null)

11
modules/feature-management/test/Volo.Abp.FeatureManagement.Domain.Tests/Volo/Abp/FeatureManagement/FeatureManager_Tests.cs

@ -209,4 +209,15 @@ public class FeatureManager_Tests : FeatureManagementDomainTestBase
(await _featureManager.GetOrNullAsync(TestFeatureDefinitionProvider.BackupCount, TenantFeatureValueProvider.ProviderName, TestEditionIds.TenantId.ToString())).ShouldBe("0");
}
[Fact]
public async Task Set_Should_Throw_Exception_If_Provider_Not_Found()
{
var exception = await Assert.ThrowsAsync<AbpException>(async () =>
{
await _featureManager.SetAsync(TestFeatureDefinitionProvider.EmailSupport, "true", "UndefinedProvider", "Test");
});
exception.Message.ShouldBe("Unknown feature value provider: UndefinedProvider");
}
}

15
modules/permission-management/test/Volo.Abp.PermissionManagement.Domain.Tests/Volo/Abp/PermissionManagement/PermissionManager_Tests.cs

@ -134,6 +134,21 @@ public class PermissionManager_Tests : PermissionTestBase
"Test",
true);
}
[Fact]
public async Task Set_Should_Throw_Exception_If_Provider_Not_Found()
{
var exception = await Assert.ThrowsAsync<AbpException>(async () =>
{
await _permissionManager.SetAsync(
"MyPermission1",
"UndefinedProvider",
"Test",
true);
});
exception.Message.ShouldBe("Unknown permission management provider: UndefinedProvider");
}
[Fact]
public async Task UpdateProviderKey()

2
modules/setting-management/src/Volo.Abp.SettingManagement.Domain/Volo/Abp/SettingManagement/SettingManager.cs

@ -125,7 +125,7 @@ public class SettingManager : ISettingManager, ISingletonDependency
if (!providers.Any())
{
throw new AbpException($"Could not find a setting provider named '{providerName}'.");
throw new AbpException($"Unknown setting value provider: {providerName}");
}
if (setting.IsEncrypted)

7
modules/setting-management/test/Volo.Abp.SettingManagement.Tests/Volo/Abp/SettingManagement/SettingManager_Basic_Tests.cs

@ -1,3 +1,4 @@
using System;
using System.Threading.Tasks;
using Shouldly;
using Volo.Abp.Settings;
@ -65,13 +66,13 @@ public class SettingManager_Basic_Tests : SettingsTestBase
}
[Fact]
public async Task Should_Throw_Exception_If_Provider_Not_Found()
public async Task Set_Should_Throw_Exception_If_Provider_Not_Found()
{
var exception = await Assert.ThrowsAsync<AbpException>(async () =>
{
await _settingManager.SetAsync("MySetting1", "43", "UndefinedProvider", "UndefinedProviderKey");
await _settingManager.SetAsync("MySetting1", "43", "UndefinedProvider", "Test");
});
exception.Message.ShouldBe("Could not find a setting provider named 'UndefinedProvider'.");
exception.Message.ShouldBe("Unknown setting value provider: UndefinedProvider");
}
}
Loading…
Cancel
Save