From 516e3c6f8a644bb1f81be49293a04afe34d0654c Mon Sep 17 00:00:00 2001 From: TheDiaval Date: Thu, 15 Aug 2019 15:05:01 +0300 Subject: [PATCH 1/6] refactor(theme-basic): change-password --- .../change-password/change-password.component.html | 12 +++--------- .../change-password/change-password.component.ts | 9 +++++++++ 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.html b/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.html index d1dc99b109..738a673945 100644 --- a/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.html +++ b/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.html @@ -1,9 +1,9 @@ - +

{{ 'AbpIdentity::ChangePassword' | abpLocalization }}

-
+
* {{ 'AbpIdentity::Cancel' | abpLocalization }} - {{ 'AbpIdentity::Save' | abpLocalization }} + {{ 'AbpIdentity::Save' | abpLocalization }} diff --git a/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.ts b/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.ts index fe3d8da60d..6c372a4620 100644 --- a/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.ts +++ b/npm/ng-packs/packages/theme-basic/src/lib/components/change-password/change-password.component.ts @@ -15,6 +15,7 @@ import { FormBuilder, FormGroup, Validators } from '@angular/forms'; import { comparePasswords } from '@ngx-validate/core'; import { Store } from '@ngxs/store'; import snq from 'snq'; +import { finalize } from 'rxjs/operators'; const { minLength, required } = Validators; @@ -43,6 +44,8 @@ export class ChangePasswordComponent implements OnInit, OnChanges { form: FormGroup; + modalBusy: boolean = false; + constructor(private fb: FormBuilder, private store: Store, private toasterService: ToasterService) {} ngOnInit(): void { @@ -60,6 +63,7 @@ export class ChangePasswordComponent implements OnInit, OnChanges { onSubmit() { if (this.form.invalid) return; + this.modalBusy = true; this.store .dispatch( @@ -68,6 +72,11 @@ export class ChangePasswordComponent implements OnInit, OnChanges { newPassword: this.form.get('newPassword').value, }), ) + .pipe( + finalize(() => { + this.modalBusy = false; + }), + ) .subscribe({ next: () => { this.visible = false; From 266a6697811158e33cb23ec61d49d60b0ee77eef Mon Sep 17 00:00:00 2001 From: TheDiaval Date: Thu, 15 Aug 2019 15:05:15 +0300 Subject: [PATCH 2/6] refactor(theme-basic): profile --- .../lib/components/profile/profile.component.html | 12 +++--------- .../src/lib/components/profile/profile.component.ts | 4 ++++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.html b/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.html index 921d800649..3a122357c7 100644 --- a/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.html +++ b/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.html @@ -1,9 +1,9 @@ - +

{{ 'AbpIdentity::PersonalInfo' | abpLocalization }}

- +
* @@ -36,12 +36,6 @@ - {{ 'AbpIdentity::Save' | abpLocalization }} + {{ 'AbpIdentity::Save' | abpLocalization }} diff --git a/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.ts b/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.ts index 6836ca8c28..f2e4683239 100644 --- a/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.ts +++ b/npm/ng-packs/packages/theme-basic/src/lib/components/profile/profile.component.ts @@ -32,6 +32,8 @@ export class ProfileComponent implements OnChanges { form: FormGroup; + modalBusy: boolean = false; + constructor(private fb: FormBuilder, private store: Store) {} buildForm() { @@ -54,8 +56,10 @@ export class ProfileComponent implements OnChanges { onSubmit() { if (this.form.invalid) return; + this.modalBusy = true; this.store.dispatch(new UpdateProfile(this.form.value)).subscribe(() => { + this.modalBusy = false; this.visible = false; this.form.reset(); }); From d0ff7443fe1659e0624096f22aef97c5954459f0 Mon Sep 17 00:00:00 2001 From: TheDiaval Date: Thu, 15 Aug 2019 15:05:33 +0300 Subject: [PATCH 3/6] refactor(tenant-management): tenants --- .../src/lib/components/tenants/tenants.component.html | 10 ++-------- .../src/lib/components/tenants/tenants.component.ts | 8 ++++++++ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.html b/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.html index 3f6ece30c3..9972e10220 100644 --- a/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.html +++ b/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.html @@ -90,7 +90,7 @@
- +

{{ selectedModalContent.title | abpLocalization }}

@@ -103,13 +103,7 @@ - {{ 'AbpIdentity::Save' | abpLocalization }} + {{ 'AbpIdentity::Save' | abpLocalization }}
diff --git a/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.ts b/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.ts index d2f9e271d6..64df09bc75 100644 --- a/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.ts +++ b/npm/ng-packs/packages/tenant-management/src/lib/components/tenants/tenants.component.ts @@ -52,6 +52,8 @@ export class TenantsComponent { loading: boolean = false; + modalBusy: boolean = false; + get useSharedDatabase(): boolean { return this.defaultConnectionStringForm.get('useSharedDatabase').value; } @@ -144,11 +146,13 @@ export class TenantsComponent { } saveConnectionString() { + this.modalBusy = true; if (this.useSharedDatabase) { this.tenantService .deleteDefaultConnectionString(this.selected.id) .pipe(take(1)) .subscribe(() => { + this.modalBusy = false; this.isModalVisible = false; }); } else { @@ -156,6 +160,7 @@ export class TenantsComponent { .updateDefaultConnectionString({ id: this.selected.id, defaultConnectionString: this.connectionString }) .pipe(take(1)) .subscribe(() => { + this.modalBusy = false; this.isModalVisible = false; }); } @@ -163,6 +168,7 @@ export class TenantsComponent { saveTenant() { if (!this.tenantForm.valid) return; + this.modalBusy = true; this.store .dispatch( @@ -171,6 +177,7 @@ export class TenantsComponent { : new CreateTenant(this.tenantForm.value), ) .subscribe(() => { + this.modalBusy = false; this.isModalVisible = false; }); } @@ -183,6 +190,7 @@ export class TenantsComponent { .subscribe((status: Toaster.Status) => { if (status === Toaster.Status.confirm) { this.store.dispatch(new DeleteTenant(id)); + this.modalBusy = false; } }); } From 620750f223677c23b3df225e178e422fefd38900 Mon Sep 17 00:00:00 2001 From: TheDiaval Date: Thu, 15 Aug 2019 15:05:58 +0300 Subject: [PATCH 4/6] refactor(permission-management): permission-management --- .../components/permission-management.component.html | 10 ++-------- .../lib/components/permission-management.component.ts | 5 +++++ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.html b/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.html index bc93f0df19..86326b5984 100644 --- a/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.html +++ b/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.html @@ -1,4 +1,4 @@ - +

{{ 'AbpPermissionManagement::Permissions' | abpLocalization }} - {{ data.entityName }}

@@ -86,13 +86,7 @@ - {{ 'AbpIdentity::Save' | abpLocalization }} + {{ 'AbpIdentity::Save' | abpLocalization }}
diff --git a/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.ts b/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.ts index ce5f967b00..7843958ae3 100644 --- a/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.ts +++ b/npm/ng-packs/packages/permission-management/src/lib/components/permission-management.component.ts @@ -64,6 +64,8 @@ export class PermissionManagementComponent implements OnInit, OnChanges { selectAllTab: boolean = false; + modalBusy: boolean = false; + trackByFn: TrackByFunction = (_, item) => item.name; get selectedGroupPermissions$(): Observable { @@ -175,6 +177,7 @@ export class PermissionManagementComponent implements OnInit, OnChanges { } onSubmit() { + this.modalBusy = true; const unchangedPermissions = getPermissions( this.store.selectSnapshot(PermissionManagementState.getPermissionGroups), ); @@ -195,9 +198,11 @@ export class PermissionManagementComponent implements OnInit, OnChanges { }), ) .subscribe(() => { + this.modalBusy = false; this.visible = false; }); } else { + this.modalBusy = false; this.visible = false; } } From f60b7744d8c575907635ade483535435c6377eaf Mon Sep 17 00:00:00 2001 From: TheDiaval Date: Thu, 15 Aug 2019 15:06:11 +0300 Subject: [PATCH 5/6] refactor(identity): users --- .../src/lib/components/users/users.component.html | 15 +++++---------- .../src/lib/components/users/users.component.ts | 4 ++++ 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html index 9f52238aee..ea954c55be 100644 --- a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html +++ b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.html @@ -77,14 +77,14 @@ - +

{{ (selected?.id ? 'AbpIdentity::Edit' : 'AbpIdentity::NewUser') | abpLocalization }}

- + @@ -183,14 +183,9 @@ - {{ 'AbpIdentity::Save' | abpLocalization }} + {{ + 'AbpIdentity::Save' | abpLocalization + }}
diff --git a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts index cfecf8a7af..29d8cf1de1 100644 --- a/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts +++ b/npm/ng-packs/packages/identity/src/lib/components/users/users.component.ts @@ -50,6 +50,8 @@ export class UsersComponent { loading: boolean = false; + modalBusy: boolean = false; + trackByFn: TrackByFunction = (index, item) => Object.keys(item)[0] || index; get roleGroups(): FormGroup[] { @@ -114,6 +116,7 @@ export class UsersComponent { save() { if (!this.form.valid) return; + this.modalBusy = true; const { roleNames } = this.form.value; const mappedRoleNames = snq( @@ -135,6 +138,7 @@ export class UsersComponent { }), ) .subscribe(() => { + this.modalBusy = false; this.isModalVisible = false; }); } From a3fd13945f5565a5ad5e97a2abac70dc301ca694 Mon Sep 17 00:00:00 2001 From: TheDiaval Date: Thu, 15 Aug 2019 15:06:21 +0300 Subject: [PATCH 6/6] refactor(identity): roles --- .../src/lib/components/roles/roles.component.html | 12 +++--------- .../src/lib/components/roles/roles.component.ts | 4 ++++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.html b/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.html index c6d1c70631..2acb2d3337 100644 --- a/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.html +++ b/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.html @@ -67,13 +67,13 @@ - +

{{ (selected?.id ? 'AbpIdentity::Edit' : 'AbpIdentity::NewRole') | abpLocalization }}

- +
* @@ -100,13 +100,7 @@ - {{ 'AbpIdentity::Save' | abpLocalization }} + {{ 'AbpIdentity::Save' | abpLocalization }} diff --git a/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.ts b/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.ts index 6ee14134af..baf63432c9 100644 --- a/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.ts +++ b/npm/ng-packs/packages/identity/src/lib/components/roles/roles.component.ts @@ -36,6 +36,8 @@ export class RolesComponent { loading: boolean = false; + modalBusy: boolean = false; + @ViewChild('modalContent', { static: false }) modalContent: TemplateRef; @@ -79,6 +81,7 @@ export class RolesComponent { save() { if (!this.form.valid) return; + this.modalBusy = true; this.store .dispatch( @@ -87,6 +90,7 @@ export class RolesComponent { : new CreateRole(this.form.value), ) .subscribe(() => { + this.modalBusy = false; this.isModalVisible = false; }); }