From e0c99283462640a331290b5bfbd5581428f78288 Mon Sep 17 00:00:00 2001 From: mehmet-erim Date: Sun, 5 Apr 2020 19:21:21 +0300 Subject: [PATCH] refactor: change DomInsertionsService's method name --- .../core/src/lib/services/dom-insertion.service.ts | 2 +- .../core/src/lib/tests/content.strategy.spec.ts | 10 ---------- .../core/src/lib/tests/dom-insertion.service.spec.ts | 2 +- .../theme-basic/src/lib/services/initial.service.ts | 2 +- .../src/lib/tokens/append-content.token.ts | 2 +- 5 files changed, 4 insertions(+), 14 deletions(-) diff --git a/npm/ng-packs/packages/core/src/lib/services/dom-insertion.service.ts b/npm/ng-packs/packages/core/src/lib/services/dom-insertion.service.ts index e460063d1a..f1a59e4e43 100644 --- a/npm/ng-packs/packages/core/src/lib/services/dom-insertion.service.ts +++ b/npm/ng-packs/packages/core/src/lib/services/dom-insertion.service.ts @@ -6,7 +6,7 @@ import { generateHash } from '../utils'; export class DomInsertionService { readonly inserted = new Set(); - insertElement(contentStrategy: ContentStrategy) { + insertContent(contentStrategy: ContentStrategy) { const hash = generateHash(contentStrategy.content); if (this.inserted.has(hash)) return; diff --git a/npm/ng-packs/packages/core/src/lib/tests/content.strategy.spec.ts b/npm/ng-packs/packages/core/src/lib/tests/content.strategy.spec.ts index 06042c0aee..e742313135 100644 --- a/npm/ng-packs/packages/core/src/lib/tests/content.strategy.spec.ts +++ b/npm/ng-packs/packages/core/src/lib/tests/content.strategy.spec.ts @@ -66,16 +66,6 @@ describe('ScriptContentStrategy', () => { }); }); -// describe('CONTENT_SECURITY_STRATEGY', () => { -// test.each` -// name | Strategy | nonce -// ${'Loose'} | ${LooseContentSecurityStrategy} | ${uuid()} -// ${'None'} | ${NoContentSecurityStrategy} | ${undefined} -// `('should successfully map $name to $Strategy.name', ({ name, Strategy, nonce }) => { -// expect(CONTENT_SECURITY_STRATEGY[name](nonce)).toEqual(new Strategy(nonce)); -// }); -// }); - describe('CONTENT_STRATEGY', () => { test.each` name | Strategy | domStrategy diff --git a/npm/ng-packs/packages/core/src/lib/tests/dom-insertion.service.spec.ts b/npm/ng-packs/packages/core/src/lib/tests/dom-insertion.service.spec.ts index 4153f2de08..2570636197 100644 --- a/npm/ng-packs/packages/core/src/lib/tests/dom-insertion.service.spec.ts +++ b/npm/ng-packs/packages/core/src/lib/tests/dom-insertion.service.spec.ts @@ -9,7 +9,7 @@ describe('DomInsertionService', () => { beforeEach(() => (spectator = createService())); it('should be insert an element', () => { - spectator.service.insertElement(CONTENT_STRATEGY.AppendStyleToHead('.test {}')); + spectator.service.insertContent(CONTENT_STRATEGY.AppendStyleToHead('.test {}')); expect(spectator.service.inserted.has(1437348290)).toBe(true); }); }); diff --git a/npm/ng-packs/packages/theme-basic/src/lib/services/initial.service.ts b/npm/ng-packs/packages/theme-basic/src/lib/services/initial.service.ts index 027bfaed69..2510b77a8d 100644 --- a/npm/ng-packs/packages/theme-basic/src/lib/services/initial.service.ts +++ b/npm/ng-packs/packages/theme-basic/src/lib/services/initial.service.ts @@ -28,6 +28,6 @@ export class InitialService { } appendStyle() { - this.domInsertion.insertElement(CONTENT_STRATEGY.AppendStyleToHead(styles)); + this.domInsertion.insertContent(CONTENT_STRATEGY.AppendStyleToHead(styles)); } } diff --git a/npm/ng-packs/packages/theme-shared/src/lib/tokens/append-content.token.ts b/npm/ng-packs/packages/theme-shared/src/lib/tokens/append-content.token.ts index a950c0435a..2ba7898480 100644 --- a/npm/ng-packs/packages/theme-shared/src/lib/tokens/append-content.token.ts +++ b/npm/ng-packs/packages/theme-shared/src/lib/tokens/append-content.token.ts @@ -8,7 +8,7 @@ export const THEME_SHARED_APPEND_CONTENT = new InjectionToken('THEME_SHARE factory: () => { const domInsertion: DomInsertionService = inject(DomInsertionService); - domInsertion.insertElement(CONTENT_STRATEGY.AppendStyleToHead(styles)); + domInsertion.insertContent(CONTENT_STRATEGY.AppendStyleToHead(styles)); import('chart.js').then(() => chartJsLoaded$.next(true)); },