diff --git a/src/Volo.DependencyInjection/Microsoft/Extensions/DependencyInjection/ServiceCollectionRegistrationExtensions.cs b/src/Volo.DependencyInjection/Microsoft/Extensions/DependencyInjection/ServiceCollectionRegistrationExtensions.cs index 947253505c..1eb3661534 100644 --- a/src/Volo.DependencyInjection/Microsoft/Extensions/DependencyInjection/ServiceCollectionRegistrationExtensions.cs +++ b/src/Volo.DependencyInjection/Microsoft/Extensions/DependencyInjection/ServiceCollectionRegistrationExtensions.cs @@ -1,6 +1,5 @@ using System; using System.Reflection; -using Volo.DependencyInjection; namespace Microsoft.Extensions.DependencyInjection { diff --git a/src/Volo.DependencyInjection/Volo/DependencyInjection/DefaultConventionalRegistrar.cs b/src/Volo.DependencyInjection/Volo/DependencyInjection/DefaultConventionalRegistrar.cs index dc3abf264e..62c0a01d7f 100644 --- a/src/Volo.DependencyInjection/Volo/DependencyInjection/DefaultConventionalRegistrar.cs +++ b/src/Volo.DependencyInjection/Volo/DependencyInjection/DefaultConventionalRegistrar.cs @@ -25,6 +25,8 @@ namespace Volo.DependencyInjection return; } + //TODO: Should have a list of ignored interfaces for exposed services. Say that MyTransientDependency class should not registered for ITransientDependency interface. + foreach (var serviceType in AutoRegistrationHelper.GetExposedServices(type)) { var serviceDescriptor = ServiceDescriptor.Describe(serviceType, type, lifeTime.Value); diff --git a/test/Volo.DependencyInjection.Tests/Microsoft/Extensions/DependencyInjection/AbpConventionalDependencyInjectionExtensions_Tests.cs b/test/Volo.DependencyInjection.Tests/Microsoft/Extensions/DependencyInjection/AbpConventionalDependencyInjectionExtensions_Tests.cs index 367757b8f8..c9e4126838 100644 --- a/test/Volo.DependencyInjection.Tests/Microsoft/Extensions/DependencyInjection/AbpConventionalDependencyInjectionExtensions_Tests.cs +++ b/test/Volo.DependencyInjection.Tests/Microsoft/Extensions/DependencyInjection/AbpConventionalDependencyInjectionExtensions_Tests.cs @@ -5,6 +5,9 @@ using Xunit; namespace Microsoft.Extensions.DependencyInjection { + //TODO: Add unit test for: + // - IConventionalRegistrar + public class AbpConventionalDependencyInjectionExtensions_Tests { private readonly IServiceCollection _services;