From e463d52b0269c94f5ee6675fdbb139f9af1a2bbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= Date: Tue, 3 Jan 2017 21:57:31 +0300 Subject: [PATCH] revised todos. --- src/Volo.Abp/Volo/Abp/Json/JsonExtensions.cs | 5 ++++- src/Volo.Abp/Volo/Abp/Linq/DefaultAsyncQueryableExecuter.cs | 2 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Volo.Abp/Volo/Abp/Json/JsonExtensions.cs b/src/Volo.Abp/Volo/Abp/Json/JsonExtensions.cs index e2f02eea04..d4caa3ea3f 100644 --- a/src/Volo.Abp/Volo/Abp/Json/JsonExtensions.cs +++ b/src/Volo.Abp/Volo/Abp/Json/JsonExtensions.cs @@ -5,6 +5,8 @@ namespace Volo.Abp.Json { public static class JsonExtensions { + //TODO: Remove this extension method, create IJsonSerializer abstraction (if there is not already such an abstraction). + /// /// Converts given object to JSON string. /// @@ -23,7 +25,8 @@ namespace Volo.Abp.Json options.Formatting = Formatting.Indented; } - //options.Converters.Insert(0, new AbpDateTimeConverter()); //TODO: AbpDateTimeConverter? + //TODO: AbpDateTimeConverter contains Clock, so it should be injected! + //options.Converters.Insert(0, new AbpDateTimeConverter()); return JsonConvert.SerializeObject(obj, options); } diff --git a/src/Volo.Abp/Volo/Abp/Linq/DefaultAsyncQueryableExecuter.cs b/src/Volo.Abp/Volo/Abp/Linq/DefaultAsyncQueryableExecuter.cs index 7346c07c7a..6f03eb3bc1 100644 --- a/src/Volo.Abp/Volo/Abp/Linq/DefaultAsyncQueryableExecuter.cs +++ b/src/Volo.Abp/Volo/Abp/Linq/DefaultAsyncQueryableExecuter.cs @@ -6,8 +6,6 @@ using Volo.DependencyInjection; namespace Volo.Abp.Linq { - //TODO: DefaultAsyncQueryableExecuter should be able to work with multiple Executer, each will try to execute it! - //TODO: Implement with EF Core as first executer implementation! public class DefaultAsyncQueryableExecuter : IAsyncQueryableExecuter, ITransientDependency { public Task CountAsync(IQueryable queryable)