From e58841ddfe1bce4b6384f4a7d36f8da2cbef69a9 Mon Sep 17 00:00:00 2001
From: Fahri Gedik <fahrican9978@gmail.com>
Date: Thu, 25 Sep 2025 13:07:04 +0300
Subject: [PATCH] Clean up and update test imports and providers

Replaces deprecated HttpClientModule with provideHttpClient and provideHttpClientTesting in breadcrumb tests, removes unused imports and declarations from card, error handler, and validation utils test files for improved clarity and maintainability.
---
 .../src/lib/tests/breadcrumb.component.spec.ts             | 7 ++++---
 .../theme-shared/src/lib/tests/card.component.spec.ts      | 1 -
 .../theme-shared/src/lib/tests/error.handler.spec.ts       | 3 +--
 .../theme-shared/src/lib/tests/validation-utils.spec.ts    | 2 --
 4 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts b/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts
index 0b7ac3bc5d..5f84edac4f 100644
--- a/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts
+++ b/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts
@@ -6,7 +6,8 @@ import {
   RoutesService,
   LocalizationService,
 } from '@abp/ng.core';
-import { HttpClient, HttpClientModule } from '@angular/common/http';
+import { provideHttpClient } from '@angular/common/http';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
 import { RouterModule } from '@angular/router';
 import { createRoutingFactory, SpectatorRouting } from '@ngneat/spectator/jest';
 import { BreadcrumbComponent, BreadcrumbItemsComponent } from '../components';
@@ -33,8 +34,9 @@ describe('BreadcrumbComponent', () => {
     component: RouterOutletComponent,
     stubsEnabled: false,
     detectChanges: false,
-    mocks: [HttpClient],
     providers: [
+      provideHttpClient(),
+      provideHttpClientTesting(),
       { 
         provide: CORE_OPTIONS, 
         useValue: {
@@ -61,7 +63,6 @@ describe('BreadcrumbComponent', () => {
     declarations: [],
     imports: [
       RouterModule,
-      HttpClientModule,
       LocalizationPipe,
       BreadcrumbComponent,
       BreadcrumbItemsComponent,
diff --git a/npm/ng-packs/packages/theme-shared/src/lib/tests/card.component.spec.ts b/npm/ng-packs/packages/theme-shared/src/lib/tests/card.component.spec.ts
index 1a03353565..fa474640f6 100644
--- a/npm/ng-packs/packages/theme-shared/src/lib/tests/card.component.spec.ts
+++ b/npm/ng-packs/packages/theme-shared/src/lib/tests/card.component.spec.ts
@@ -4,7 +4,6 @@ import {
   CardBodyComponent,
   CardFooterComponent,
   CardHeaderComponent,
-  CardHeaderDirective,
   CardTitleDirective,
   CardImgTopDirective,
   CardSubtitleDirective,
diff --git a/npm/ng-packs/packages/theme-shared/src/lib/tests/error.handler.spec.ts b/npm/ng-packs/packages/theme-shared/src/lib/tests/error.handler.spec.ts
index 1490bf863e..75726103d2 100644
--- a/npm/ng-packs/packages/theme-shared/src/lib/tests/error.handler.spec.ts
+++ b/npm/ng-packs/packages/theme-shared/src/lib/tests/error.handler.spec.ts
@@ -2,13 +2,12 @@ import { HttpErrorReporterService } from '@abp/ng.core';
 import { CoreTestingModule } from '@abp/ng.core/testing';
 import { APP_BASE_HREF } from '@angular/common';
 import { HttpErrorResponse, HttpHeaders } from '@angular/common/http';
-import { Component, NgModule } from '@angular/core';
+import { NgModule } from '@angular/core';
 import { createServiceFactory, SpectatorService } from '@ngneat/spectator/jest';
 import { OAuthService } from 'angular-oauth2-oidc';
 import { of, Subject } from 'rxjs';
 import { HttpErrorWrapperComponent } from '../components/http-error-wrapper/http-error-wrapper.component';
 import { ErrorHandler } from '../handlers';
-import { DEFAULT_ERROR_LOCALIZATIONS, DEFAULT_ERROR_MESSAGES } from '../constants/default-errors';
 import { ConfirmationService } from '../services';
 import { CUSTOM_ERROR_HANDLERS, HTTP_ERROR_CONFIG } from '../tokens/http-error.token';
 import { CustomHttpErrorHandlerService } from '../models';
diff --git a/npm/ng-packs/packages/theme-shared/src/lib/tests/validation-utils.spec.ts b/npm/ng-packs/packages/theme-shared/src/lib/tests/validation-utils.spec.ts
index dc8f311209..9f263779e2 100644
--- a/npm/ng-packs/packages/theme-shared/src/lib/tests/validation-utils.spec.ts
+++ b/npm/ng-packs/packages/theme-shared/src/lib/tests/validation-utils.spec.ts
@@ -2,12 +2,10 @@ import { AbpApplicationConfigurationService, ConfigStateService } from '@abp/ng.
 import { CoreTestingModule } from '@abp/ng.core/testing';
 import { HttpClient } from '@angular/common/http';
 import { Component, Injector } from '@angular/core';
-import { Validators } from '@angular/forms';
 import { createComponentFactory, Spectator } from '@ngneat/spectator/jest';
 import { OAuthService } from 'angular-oauth2-oidc';
 import { of } from 'rxjs';
 import { getPasswordValidators, validatePassword } from '../utils';
-import { PasswordRule } from '../models/validation';
 
 @Component({ template: '', selector: 'abp-dummy' })
 class DummyComponent {}