Browse Source

*remove filters variables from abstract and move to concrete class

*fix invalid generic type
pull/18577/head
masumulu28 2 years ago
parent
commit
ea7564708a
  1. 12
      npm/ng-packs/packages/core/src/lib/abstracts/auth-error-filter.ts
  2. 5
      npm/ng-packs/packages/oauth/src/lib/services/oauth-error-filter.service.ts

12
npm/ng-packs/packages/core/src/lib/abstracts/auth-error-filter.ts

@ -1,10 +1,6 @@
import { signal } from '@angular/core';
import { AuthErrorEvent, AuthErrorFilter } from '../models';
export abstract class AbstractAuthErrorFilter<T, E> {
protected readonly _filters = signal<Array<T>>([]);
readonly filters = this._filters.asReadonly();
abstract get(id: string): T;
abstract add(filter: T): void;
abstract patch(item: Partial<T>): void;
@ -13,8 +9,8 @@ export abstract class AbstractAuthErrorFilter<T, E> {
}
export class AuthErrorFilterService<
T = AuthErrorEvent,
E = AuthErrorFilter,
T = AuthErrorFilter,
E = AuthErrorEvent,
> extends AbstractAuthErrorFilter<T, E> {
private warningMessage() {
console.error('You should add @abp/ng-oauth packages or create your own auth packages.');
@ -24,15 +20,19 @@ export class AuthErrorFilterService<
this.warningMessage();
throw new Error('not implemented');
}
add(filter: T): void {
this.warningMessage();
}
patch(item: Partial<T>): void {
this.warningMessage();
}
remove(id: string): void {
this.warningMessage();
}
run(event: E): boolean {
this.warningMessage();
throw new Error('not implemented');

5
npm/ng-packs/packages/oauth/src/lib/services/oauth-error-filter.service.ts

@ -1,4 +1,4 @@
import { Injectable } from '@angular/core';
import { Injectable, signal } from '@angular/core';
import { OAuthErrorEvent } from 'angular-oauth2-oidc';
import { AbstractAuthErrorFilter, AuthErrorFilter } from '@abp/ng.core';
@ -7,6 +7,9 @@ export class OAuthErrorFilterService extends AbstractAuthErrorFilter<
AuthErrorFilter<OAuthErrorEvent>,
OAuthErrorEvent
> {
protected readonly _filters = signal<Array<AuthErrorFilter<OAuthErrorEvent>>>([]);
readonly filters = this._filters.asReadonly();
get(id: string): AuthErrorFilter<OAuthErrorEvent> {
return this._filters().find(({ id: _id }) => _id === id);
}

Loading…
Cancel
Save