Browse Source

fix: missing tagnames in bootstrap tag helpers

resolves https://github.com/volosoft/volo/issues/2807
pull/4797/head
Yunus Emre Kalkan 6 years ago
parent
commit
f4bb99b317
  1. 2
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Blockquote/AbpBlockquoteFooterTagHelper.cs
  2. 2
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Blockquote/AbpBlockquoteParagraphTagHelper.cs
  3. 3
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Blockquote/AbpBlockquoteTagHelperService.cs
  4. 7
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Breadcrumb/AbpBreadcrumbTagHelperService.cs
  5. 4
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Button/AbpButtonGroupTagHelperService.cs
  6. 3
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Button/AbpButtonToolbarTagHelperService.cs
  7. 4
      framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Collapse/AbpAccordionItemTagHelperService.cs

2
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Blockquote/AbpBlockquoteFooterTagHelper.cs

@ -2,7 +2,7 @@
namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Blockquote namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Blockquote
{ {
[HtmlTargetElement("footer", ParentTag = "abp-blockquote")] [HtmlTargetElement("footer", ParentTag = "blockquote")]
public class AbpBlockquoteFooterTagHelper : AbpTagHelper<AbpBlockquoteFooterTagHelper, AbpBlockquoteFooterTagHelperService> public class AbpBlockquoteFooterTagHelper : AbpTagHelper<AbpBlockquoteFooterTagHelper, AbpBlockquoteFooterTagHelperService>
{ {
public AbpBlockquoteFooterTagHelper(AbpBlockquoteFooterTagHelperService tagHelperService) public AbpBlockquoteFooterTagHelper(AbpBlockquoteFooterTagHelperService tagHelperService)

2
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Blockquote/AbpBlockquoteParagraphTagHelper.cs

@ -2,7 +2,7 @@
namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Blockquote namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Blockquote
{ {
[HtmlTargetElement("p", ParentTag = "abp-blockquote")] [HtmlTargetElement("p", ParentTag = "blockquote")]
public class AbpBlockquoteParagraphTagHelper : AbpTagHelper<AbpBlockquoteParagraphTagHelper, AbpBlockquoteParagraphTagHelperService> public class AbpBlockquoteParagraphTagHelper : AbpTagHelper<AbpBlockquoteParagraphTagHelper, AbpBlockquoteParagraphTagHelperService>
{ {
public AbpBlockquoteParagraphTagHelper(AbpBlockquoteParagraphTagHelperService tagHelperService) public AbpBlockquoteParagraphTagHelper(AbpBlockquoteParagraphTagHelperService tagHelperService)

3
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Blockquote/AbpBlockquoteTagHelperService.cs

@ -8,6 +8,7 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Blockquote
public override void Process(TagHelperContext context, TagHelperOutput output) public override void Process(TagHelperContext context, TagHelperOutput output)
{ {
output.Attributes.AddClass("blockquote"); output.Attributes.AddClass("blockquote");
output.TagName = "blockquote";
} }
} }
} }

7
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Breadcrumb/AbpBreadcrumbTagHelperService.cs

@ -13,9 +13,12 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Breadcrumb
var list = InitilizeFormGroupContentsContext(context, output); var list = InitilizeFormGroupContentsContext(context, output);
await output.GetChildContentAsync(); await output.GetChildContentAsync();
SetInnerOlTag(context, output); SetInnerOlTag(context, output);
SetInnerList(context, output, list); SetInnerList(context, output, list);
output.TagName = "nav";
output.Attributes.Add("aria-label", "breadcrumb");
} }
protected virtual void SetInnerOlTag(TagHelperContext context, TagHelperOutput output) protected virtual void SetInnerOlTag(TagHelperContext context, TagHelperOutput output)
@ -63,4 +66,4 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Breadcrumb
} }
} }
} }

4
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Button/AbpButtonGroupTagHelperService.cs

@ -11,6 +11,8 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Button
AddButtonGroupClass(context, output); AddButtonGroupClass(context, output);
AddSizeClass(context, output); AddSizeClass(context, output);
AddAttributes(context, output); AddAttributes(context, output);
output.TagName = "div";
} }
protected virtual void AddSizeClass(TagHelperContext context, TagHelperOutput output) protected virtual void AddSizeClass(TagHelperContext context, TagHelperOutput output)
@ -52,4 +54,4 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Button
output.Attributes.Add("role", "group"); output.Attributes.Add("role", "group");
} }
} }
} }

3
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Button/AbpButtonToolbarTagHelperService.cs

@ -7,8 +7,9 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Button
{ {
public override void Process(TagHelperContext context, TagHelperOutput output) public override void Process(TagHelperContext context, TagHelperOutput output)
{ {
output.TagName = "div";
output.Attributes.AddClass("btn-toolbar"); output.Attributes.AddClass("btn-toolbar");
output.Attributes.Add("role","toolbar"); output.Attributes.Add("role","toolbar");
} }
} }
} }

4
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Collapse/AbpAccordionItemTagHelperService.cs

@ -23,8 +23,6 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Collapse
output.SuppressOutput(); output.SuppressOutput();
} }
protected virtual string GetAccordionHeaderItem(TagHelperContext context, TagHelperOutput output) protected virtual string GetAccordionHeaderItem(TagHelperContext context, TagHelperOutput output)
{ {
return " <div class=\"card-header\" id=\"" + GetHeadingId() + "\">" + Environment.NewLine + return " <div class=\"card-header\" id=\"" + GetHeadingId() + "\">" + Environment.NewLine +
@ -64,4 +62,4 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Collapse
} }
} }
} }
} }

Loading…
Cancel
Save