From f4edd5ce6baaf5f9de4340a8654e703e36f89347 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20=C4=B0brahim=20Kalkan?= Date: Wed, 14 Dec 2016 10:53:22 +0300 Subject: [PATCH] Added TODOs. --- .../Volo/Abp/Application/Services/Dtos/EntityDto.cs | 2 ++ .../DependencyInjection/AbpDbContextConfigurationContext.cs | 2 +- .../EntityFrameworkCore/DefaultDbContextProvider.cs | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Volo.Abp.ApplicationContracts/Volo/Abp/Application/Services/Dtos/EntityDto.cs b/src/Volo.Abp.ApplicationContracts/Volo/Abp/Application/Services/Dtos/EntityDto.cs index 6f26fec97b..7fab20c981 100644 --- a/src/Volo.Abp.ApplicationContracts/Volo/Abp/Application/Services/Dtos/EntityDto.cs +++ b/src/Volo.Abp.ApplicationContracts/Volo/Abp/Application/Services/Dtos/EntityDto.cs @@ -1,5 +1,7 @@ namespace Volo.Abp.Application.Services.Dtos { + //TODO: Add [Serializable] to all DTOs and Entities when .Net Standard 2.0 is available. + /// /// Implements common properties for entity based DTOs. /// diff --git a/src/Volo.Abp.EntityFrameworkCore/Microsoft/Extensions/DependencyInjection/AbpDbContextConfigurationContext.cs b/src/Volo.Abp.EntityFrameworkCore/Microsoft/Extensions/DependencyInjection/AbpDbContextConfigurationContext.cs index ea41aa3b01..2d105ddf82 100644 --- a/src/Volo.Abp.EntityFrameworkCore/Microsoft/Extensions/DependencyInjection/AbpDbContextConfigurationContext.cs +++ b/src/Volo.Abp.EntityFrameworkCore/Microsoft/Extensions/DependencyInjection/AbpDbContextConfigurationContext.cs @@ -8,7 +8,7 @@ namespace Microsoft.Extensions.DependencyInjection { public string ConnectionString { get; } - public string ModuleName { get; } + public string ModuleName { get; } //TODO: Use a SchemaName/DatabaseName instead? public virtual DbContextOptionsBuilder DbContextOptions { get; protected set; } diff --git a/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Repositories/EntityFrameworkCore/DefaultDbContextProvider.cs b/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Repositories/EntityFrameworkCore/DefaultDbContextProvider.cs index 30654e264c..c06f975b69 100644 --- a/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Repositories/EntityFrameworkCore/DefaultDbContextProvider.cs +++ b/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Repositories/EntityFrameworkCore/DefaultDbContextProvider.cs @@ -7,7 +7,7 @@ namespace Volo.Abp.Repositories.EntityFrameworkCore { private readonly TDbContext _dbContext; - public DefaultDbContextProvider(TDbContext dbContext) + public DefaultDbContextProvider(TDbContext dbContext) //TODO: Should create this dynamically! { _dbContext = dbContext; }